From: "Douglas, William" <william.douglas@intel.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] print_frame add info
Date: Tue, 18 Dec 2012 21:52:00 -0000 [thread overview]
Message-ID: <CABhPDt9nwBV+O_rfR+-44rzkucdSP834rQmfgUKuPRNuX2_4bw@mail.gmail.com> (raw)
In-Reply-To: <877goftkcc.fsf@fleche.redhat.com>
On Tue, Dec 18, 2012 at 8:07 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> * IMO it should be before the function name so that one can
> Jan> copy-paste it as a linespec to "break" and other commands. But
> Jan> linespec should be able to parse "objectname:funcname" which it
> Jan> currently cannot.
>
> Jan> And I was not sure how well will one parse "objectname:funcname" in
> Jan> linespec, Keith Seitz is rewriting the linespec parser somehow.
>
> I don't think the linespec change should be a prerequisite to changing
> how the stack frame is displayed.
> I agree with your other points though.
>
Okay so would a patch be acceptable with iam's original changes
getting updated per that thread then?
next prev parent reply other threads:[~2012-12-18 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 1:40 William Douglas
2012-12-18 8:33 ` Jan Kratochvil
2012-12-18 16:08 ` Tom Tromey
2012-12-18 21:52 ` Douglas, William [this message]
2012-12-19 7:07 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABhPDt9nwBV+O_rfR+-44rzkucdSP834rQmfgUKuPRNuX2_4bw@mail.gmail.com \
--to=william.douglas@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox