From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18289 invoked by alias); 18 Dec 2012 21:52:28 -0000 Received: (qmail 18281 invoked by uid 22791); 18 Dec 2012 21:52:27 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga10.intel.com (HELO fmsmga102.fm.intel.com) (192.55.52.92) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 21:52:24 +0000 Received: from mail-qc0-f198.google.com ([209.85.216.198]) by mga11.intel.com with ESMTP/TLS/RC4-SHA; 18 Dec 2012 13:52:23 -0800 Received: by mail-qc0-f198.google.com with SMTP id l35so1786463qco.1 for ; Tue, 18 Dec 2012 13:52:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=JC9F2SihBRQocn796qu99abC6fZASwD2ogncyJpyw/c=; b=H7BAQHzIYHfYoGGEsB1wEMoUd+nAEMc45FiulBFb9yOJBgBO3QIP6k2zkJ5VLAarNn p7BAAh4+2HLGAsxwIZ4fQazEZ60KXL6SX54VcXXypkvPMpHte0DqxAnkS6eqHqShUOuf cUXWI2UQt1XKRinwyoNdjGgVM/LaiP77CBTg++3BITnlZCNqIBwggYyTS9pnefRJgya5 jQFeOoai10Z6CMyy1yF9HGdYSTohmvIvJdMFsI3DCle65jJ4KHy01JFRbpGEnlBhDQ4w odfF0ioJP7zXguvq/23tjcvwKdfAuB9+QOkKqcDjhxFjq7pb8O7W5qWsG/y8Z/dCnqSg AYfg== X-Received: by 10.49.74.198 with SMTP id w6mr1642626qev.57.1355867542073; Tue, 18 Dec 2012 13:52:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.49.74.198 with SMTP id w6mr1642624qev.57.1355867541986; Tue, 18 Dec 2012 13:52:21 -0800 (PST) Received: by 10.229.212.20 with HTTP; Tue, 18 Dec 2012 13:52:21 -0800 (PST) In-Reply-To: <877goftkcc.fsf@fleche.redhat.com> References: <87ehiocel0.fsf@intel.com> <20121218083252.GA8054@host2.jankratochvil.net> <877goftkcc.fsf@fleche.redhat.com> Date: Tue, 18 Dec 2012 21:52:00 -0000 Message-ID: Subject: Re: [PATCH] print_frame add info From: "Douglas, William" To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnQVJs5hryU08P+9N7pGDX0oXkY2k+0EhsWXvlmDZduZpcF/0SUzbew+BD7MGTeJkBohXFGRVHxXQni3roENB+VxNmMfj3qmSK3VrMNYJCCrai6MbuAKOqK+wQsCeu5Kx1JNAeOSAwRa5yLPhcFNorWSrMkIw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00666.txt.bz2 On Tue, Dec 18, 2012 at 8:07 AM, Tom Tromey wrote: >>>>>> "Jan" == Jan Kratochvil writes: > > Jan> * IMO it should be before the function name so that one can > Jan> copy-paste it as a linespec to "break" and other commands. But > Jan> linespec should be able to parse "objectname:funcname" which it > Jan> currently cannot. > > Jan> And I was not sure how well will one parse "objectname:funcname" in > Jan> linespec, Keith Seitz is rewriting the linespec parser somehow. > > I don't think the linespec change should be a prerequisite to changing > how the stack frame is displayed. > I agree with your other points though. > Okay so would a patch be acceptable with iam's original changes getting updated per that thread then?