Re: [PATCH v2] Use "output-radix" setting to format function offsets

[Zander Work <zdw@google.com>]

On Tue, May 12, 2026 at 4:33 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Zander Work <zdw@google.com>
> > Cc: guinevere@redhat.com,
> >       tom@tromey.com,
> >       Zander Work <zdw@google.com>
> > Date: Mon, 11 May 2026 18:32:38 -0700
> >
> > Thank you for the review Guinevere! I fixed the formatting issue you
> > flagged, and added your review tag.
> >
> > Global maintainers: I haven't done a FSF copyright assignment, please
> > let me know how I should do that.
>
> If you are an employee of Google, I think they have a blanket
> assignment covering all of their employees?  Tom, am I right?

Our internal documentation says that Google has a CLA on file with
FSF, but the red warning on the Contributor Guide section 6 [1] makes
me think that isn't sufficient

[1] https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assignment

>
> Failing that, we can send you the form to fill and the instructions to
> go with it, so you could start your assignment paperwork rolling.
>
> > This is a patch for a discussion [1] I had previously where it was
> > determined that it was a bug for GDB to not use the "output-radix"
> > setting for function offsets.
> >
> > This patch includes updates to the radix.exp tests, and I verified that
> > there were no new breakages added when running the full gdb testsuite
> > with this patch.
> >
> > I didn't make any changes to NEWS or a /gdb/ Changelog entry for this,
> > if I should please let me know.
>
> Yes, this needs an entry in NEWS.  I think the descriptions of
> output-radix and of the "disassemble" command in the GDB manual should
> also be updated to reflect the change.

Sure thing, will update this patch with that later today.

>
> Thanks.