Re: [PATCH v2] Use "output-radix" setting to format function offsets

[Tom Tromey <tom@tromey.com>]

>>>>> Zander Work <zdw@google.com> writes:

> Updates since v1:
[...]

It's normal in gdb for the commit message to describe the purpose of the
patch.

> +std::string
> +format_pc_offset (int offset)
> +{
> +  std::string sign = (offset < 0) ? "-" : "+";
> +
> +  std::string body = int_string (offset < 0 ? -offset : offset, output_radix,
> +                                 0, 0, 1);

I don't have any objection to this but I wanted to note that using the
output radix is kind of heavy, since it affects all sorts of output.

That is, I tend to think a new option would be preferable.  Though,
unfortunately, that would be more work since it would involve more
documentation at least.

Another possibility is that nobody really even wants decimal here and
that using hex always would be fine.  I mean -- that would be fine by me
but we should see if anyone feels differently.

Finally, I think print_address_symbolic should probably do the same
thing, i.e., it needs an update:

  if (offset != 0)
    gdb_printf (stream, "%+d", offset);

thanks,
Tom