From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4Z/pGMglA2qujDMAWB0awg (envelope-from ) for ; Tue, 12 May 2026 09:06:16 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=lFEwVeSX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6164A1E0C3; Tue, 12 May 2026 09:06:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.9 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A79771E093 for ; Tue, 12 May 2026 09:06:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C655F4BAE7C7 for ; Tue, 12 May 2026 13:06:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C655F4BAE7C7 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=lFEwVeSX Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 8FEE94BA2E06 for ; Tue, 12 May 2026 13:05:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FEE94BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FEE94BA2E06 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2607:f8b0:4864:20::82d ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778591138; cv=pass; b=xdfYlQDcuLaKG2sgaRqoooKOKjRzjr08/TKFqGgJ5dazJixW+z0xS7/QlX3HIDyOGvZsCJqbEELrmqs6nBGju231rptMsaChaU2Oh+DhZxenBgg7QoPRVP/YljW3MRoZtycMQPrCsBLZUSODy5BLhMSId+XcBmAAKwmjiRyoLzg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778591138; c=relaxed/simple; bh=8S4o7DQeJimTEcaAcXTR7pIboFBylHQq8XAGKVwkG7c=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=VKC9sxCk5FuhPQuHHY12UCTrNsLSgxOy7Gjc56tLbaOAmWovGBWfypZ3KAgw1VKr6XDtpgEZrkrjVdx7EzHIiYu0oW699rKs9kSBjx6nnap/WDxJk5U3HxMU2mfeSdy0FcvYlwgKlsNxgSJFp8wfvVIeTO/5HJ9JwIhz6ChSXZo= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=lFEwVeSX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FEE94BA2E06 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-50d864c23bdso1401cf.1 for ; Tue, 12 May 2026 06:05:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778591138; cv=none; d=google.com; s=arc-20240605; b=PkypXdOd8GV2L1StWnJZZ5vfdtE8tVovdHtbbvimMkQF3gm50b6fXyvSirsLBA7GRz vJtfrRq5LW6GGSJftaJ7dJn8b3lf80iHD8GXyu1IO0Z/OBMJD6fzR9whDzU1LnkVGQuQ S9heXPwthxMbyEkaZPgyDYa6QFt8PSEZ6vBlPDqf5/JutknK5gqw0/I3PN4ihVSgCIxT weSoWX+d/osBXMo6hg5gzttlmvaU+udjbF55wG3+7rQs+vqLnHynB+hH4tvh2hFQ2N6I fwXB1uErkyOcDbXNJPuD7AlVln6q7zkYGkk2Yldj1laGaMvWcUaUETZXguvD5wj/BPIx JGaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=97cUFle5YxE7QGncSB3B8ELhLntmW+zvu1Yf2oSYxuQ=; fh=G4MhI3iUzr0jl7XIYqtpwRKjUl+BuBDLeZXMYUYdm1Q=; b=Q12bi8KrnFsAeepTVFy7HvPi0k4pLY/WUFJ+njbdc5NJCOX2r7gWglD+rl9QqhCxt6 6WK/8NQYMgkLZtL2VXRpWnpZkFe+miVyPkEjT/MGiv8GZKb4IHeFJobxGuSv1+JfmAEw GMO0kbKhVTyRwDfky6iorTa4kPE1mBCNF8T+FHWxLGUWr1Jk8z6fTG/I1TNjzcjJ+daw zes0op9PEL1QZjrjAZQwWpijDzqXP36sEu14fdanz5Y3cFuNmvpWiD+dAujZWgwYsUzD m5TtLy1xo09Q4M7fUtroUOZ943B5xAbo5kFICrvOUf2MAJQlO6nqo2u+w/I3HCniz3jE oX7w==; darn=sourceware.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778591138; x=1779195938; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=97cUFle5YxE7QGncSB3B8ELhLntmW+zvu1Yf2oSYxuQ=; b=lFEwVeSX62ir7ySvQLmcyFTiXpFBpzdxz7AQewWmBRXw4Sb7l736mWOTfmaIIizJnp IItbJ5J96auNqY2N9K2VB11KsmhsEJtiMmBA0gKQSOK1a29hpAloNwvNoBdrqnRuCAfW X3q2OOJYWA1U1HVwPwNrv9cmTQZ/hAupjVc1IHjqqtEBeOmCRP5ifuYgc6IQ+8QhqHjX MHF5WAUIF01n9ip/uJRWVoxLotkWhC4xsm4ycs8nuSkx+d+K2SrAPqZJ955BurmH4BbB Hw6VnTeLiFxctJupnuocDu0gvKgETPBherRVY/OkO7fN8qmPIG7Cyh//gCnia0ncbRjJ VpYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778591138; x=1779195938; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=97cUFle5YxE7QGncSB3B8ELhLntmW+zvu1Yf2oSYxuQ=; b=nK6dvu9kwNrcYtFPhQcULuKh8e3U4OaZhdPoioF45/ExqCIIc8qIvmRUSppWssHPPb 3XhoOXrPhqjjX9yOqVJh2ynXV+KT+ygbxBNEm2xXkoV5hgVzxw0u7ScJZOFaSkEihhL7 fBd0dQZCfssMgyupeJhThSMHB0u6YiXo1r4xIIsZo/COJ/Gi+D/J3ReK4GExWzmKbQfY jcsxJfAnijsDOKeWoOUphPWSgdrbXb/lKP5bCqPwLTOrBtlWNZGZ9HNBbfmJUegu77uy RH8Uocbw5d/a6uqbSCMD8EOtoOcYitC5Xew/Q+ZSltmVCpCaGEo06+mUwbJ0WnW4Vs1i dKNg== X-Gm-Message-State: AOJu0YxjpAf9YmNXDp8cS1C9Fgz6W/Fj1f0O8zU/0gW/j7PLhQ7Sl6b0 q+EFPjUUUhlz3w58qBLgnt5bEx+f6HAeFLfrxOvV5dUEAveIfioqFu/yqCTQefHCpMop+TEIvQV q5hIXeE/rmYifvNoUAqqLx+WtcmbTTOc5gUCJQnIAK4IX3vwu+pDYsmVXycg= X-Gm-Gg: Acq92OHBsXnNaCP2kArv9PvAFaLwN2yzmCgSI8R2BF6z/BHWLYGBo8dytxCRDKxik6Y enQdPWXRTRgZy5w0Ypu9gpRTwMUQf1s54FjzWW9cuvtv07+ZI7VHlfi8F6Tnek8bojBYF75uGTF 83NqOZ3UWryapN08ybX+B3eiyTv5K8vioA7XStBN9RHVp1QjweGBs4sbsruENEqA37uf0+IX2/J LRIU4WIlSvX8sdl75udqJG8whK0XecupeI4K1R7hYNWsp6eLOSTmQZu+na7RIBxlQGAEJZSdzRL d+YtcfZamytUC4/YPauNufXoZJkKdXqTojtWbZN0N3c5Rm531cgCFSTxMZJ/k6ko8w5WCnZkEq2 U1U+9YO3MgBsE X-Received: by 2002:a05:622a:191a:b0:4ff:c0e7:be9c with SMTP id d75a77b69052e-514d4126596mr12155971cf.0.1778591137328; Tue, 12 May 2026 06:05:37 -0700 (PDT) MIME-Version: 1.0 References: <350b3a8d-3174-4703-b532-4ba49fe5ea05@redhat.com> <20260512013237.646630-2-zdw@google.com> <86zf24zwta.fsf@gnu.org> In-Reply-To: <86zf24zwta.fsf@gnu.org> From: Zander Work Date: Tue, 12 May 2026 06:05:21 -0700 X-Gm-Features: AVHnY4ITzWoXNpmq4g290i_ASujcfIgzznR5EVGBuZWQExfoug6LO9v8U3lth6g Message-ID: Subject: Re: [PATCH v2] Use "output-radix" setting to format function offsets To: Eli Zaretskii Cc: gdb-patches@sourceware.org, guinevere@redhat.com, tom@tromey.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, May 12, 2026 at 4:33=E2=80=AFAM Eli Zaretskii wrote: > > > From: Zander Work > > Cc: guinevere@redhat.com, > > tom@tromey.com, > > Zander Work > > Date: Mon, 11 May 2026 18:32:38 -0700 > > > > Thank you for the review Guinevere! I fixed the formatting issue you > > flagged, and added your review tag. > > > > Global maintainers: I haven't done a FSF copyright assignment, please > > let me know how I should do that. > > If you are an employee of Google, I think they have a blanket > assignment covering all of their employees? Tom, am I right? Our internal documentation says that Google has a CLA on file with FSF, but the red warning on the Contributor Guide section 6 [1] makes me think that isn't sufficient [1] https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Ass= ignment > > Failing that, we can send you the form to fill and the instructions to > go with it, so you could start your assignment paperwork rolling. > > > This is a patch for a discussion [1] I had previously where it was > > determined that it was a bug for GDB to not use the "output-radix" > > setting for function offsets. > > > > This patch includes updates to the radix.exp tests, and I verified that > > there were no new breakages added when running the full gdb testsuite > > with this patch. > > > > I didn't make any changes to NEWS or a /gdb/ Changelog entry for this, > > if I should please let me know. > > Yes, this needs an entry in NEWS. I think the descriptions of > output-radix and of the "disassemble" command in the GDB manual should > also be updated to reflect the change. Sure thing, will update this patch with that later today. > > Thanks.