Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c

[Doug Evans <dje@sebabeach.org>]

WTF?  Where'd the patch go?
Let's try this again.

On Sat, Nov 9, 2013 at 11:47 AM, Doug Evans <dje@sebabeach.org> wrote:
> On Thu, Nov 7, 2013 at 8:40 AM, Doug Evans <dje@sebabeach.org> wrote:
>> On Thu, Nov 7, 2013 at 6:36 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>>> "Doug" == Doug Evans <dje@sebabeach.org> writes:
>>>
>>> Doug> Tom Tromey <tromey@redhat.com> writes:
>>> Stan> +/* A helper function for tyscm_richcompare that checks two types for
>>> Stan> +   "deep" equality.  Returns non-zero if the types are considered the
>>> Stan> +   same, zero otherwise.  */
>>>>>
>>> Stan> "tyscm_richcompare"?  Should that be typy_... ?
>>>>>
>>>>> It would be helpful if Doug could list all the change he made when
>>>>> moving the code.
>>>
>>> Doug> I don't understand.
>>> Doug> Which changes?  While useful beyond its present state, this is in
>>> Doug> essence just a cleanup.
>>>
>>> I had thought this patch was more or less a straight move of the code.
>>> But Stan's note revealed a change from what is currently in the tree.
>>> So the question is, can you say what else changed?
>>> That would be handy so I don't have to go over it line-by-line myself.
>>
>> Ah.  Except for the comment (*1) the only substantive change is in the result:
>> Py_{NE,EQ} -> 0.1.
>>
>> (*1): Early on I made a copy because I wasn't sure how things would end up,
>> and left in a FIXME to remind myself to revisit.
>> I revisited and realized there's no need for the copy, but missed the
>> comment.  Blech.
>> "diff -b before after" shows nothing of note to me.
>
> Here's v2 of the patch.
>
> I fixed the comment and added an assert to check type1,type2 != NULL.
>
> I changed the email address in the ChangeLog entry 'cus I'm having
> problems with this domain.
> After this email hopefully the switchover is complete.