From: Doug Evans <xdje42@gmail.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c
Date: Fri, 22 Nov 2013 07:40:00 -0000 [thread overview]
Message-ID: <m31u29njja.fsf@sspiff.org> (raw)
In-Reply-To: <CAP9bCMSKMw1h6UVobEz_7R01OQFS8EoL8mf0podqiYGhBCzRrw@mail.gmail.com> (Doug Evans's message of "Sun, 17 Nov 2013 09:58:55 -0800")
Doug Evans <xdje42@gmail.com> writes:
> On Thu, Nov 14, 2013 at 9:24 AM, Doug Evans <xdje42@gmail.com> wrote:
>> On Sat, Nov 9, 2013 at 11:54 AM, Doug Evans <xdje42@gmail.com> wrote:
>>> Ok, no more attachment.
>>>
>>> 2013-11-09 Doug Evans <xdje42@gmail.com>
>>>
>>> * gdbtypes.c: #include bcache.h, dwarf2loc.h.
>>> (type_equality_entry): Move here from python/py-type.c.
>>> (type_equality_entry_d): Ditto.
>>> (compare_maybe_null_strings, check_types_equal): Ditto.
>>> (check_types_worklist, types_deeply_equal): Ditto.
>>> * gdbtypes.h (types_deeply_equal): Declare.
>>> * python/py-type.c: Remove inclusion of bcache.h, dwarf2loc.h.
>>> (typy_richcompare): Update.
>>
>> Ping.
>
> Since this is just a simple cleanup, there's no real need to put
> someone to the trouble of doing a code review so I think I'm just
> going to check this in.
>
> Guess I should have just submitted it that way in the first place.
> Good thing to know for next time.
Committed.
next prev parent reply other threads:[~2013-11-22 4:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 17:10 Doug Evans
2013-11-06 21:35 ` Stan Shebs
2013-11-06 21:50 ` Tom Tromey
2013-11-07 7:17 ` Doug Evans
2013-11-07 14:53 ` Tom Tromey
[not found] ` <CAA8o+=T2a8WLE8zi1NO=u8B460KmwOvA2m2pzVJCkAsXw6vHBw@mail.gmail.com>
2013-11-09 19:50 ` Doug Evans
2013-11-09 19:55 ` Doug Evans
2013-11-09 20:33 ` Doug Evans
[not found] ` <CAP9bCMQa7g0vupyHKwmZKum1QJDToDL7bCj92Sc6xbV9R71KGg@mail.gmail.com>
2013-11-17 19:34 ` Doug Evans
2013-11-22 7:40 ` Doug Evans [this message]
2013-11-07 7:11 ` Doug Evans
2013-11-07 10:19 ` Publishing binary interfaces [was Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c] Doug Evans
2013-11-11 18:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31u29njja.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox