From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12534 invoked by alias); 9 Nov 2013 19:50:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12525 invoked by uid 89); 9 Nov 2013 19:50:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-wg0-f54.google.com Received: from Unknown (HELO mail-wg0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 09 Nov 2013 19:50:56 +0000 Received: by mail-wg0-f54.google.com with SMTP id c11so3259209wgh.9 for ; Sat, 09 Nov 2013 11:50:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=tyvCqrtBKMskay4EpDcQzGtWvmVXHSoouCx6zqWFNO0=; b=JXiyhpxG7RP7pU0KnpxZiOxFPQ6E3ncMi5CkgWNPKFE2/1az050B38eSCfXduaXDu7 6vydLwxzyXdCW2I2tvEvE/App3j9ujZ0ADyWNE3WQGTJkebl5S6vVBd8ghBLLA6K1YG2 5QNam/smiIDGReEZkhlWuAG/YYJz4G6MAskz+YF7uiWZHj86N55CmHZC4bU8Tr8TF+5e vul/4wwrSQdTmvfT1Kx5ThO/BcEQ01I9TCdQGa3ScRdzHHIBZWD8x/GH/YP2CT0ohPbZ lTrCWg08v/iZ30V9zyPXzXo4ko3NB2d1b4V1NWCEML125czn0z6GuukgXn3u+9IVDwey 9xIw== X-Gm-Message-State: ALoCoQl89EG7tT4L/EehkedPQUQNdl0awwFdPyHZkGFPmJ4G7Eiq7w+/RWEZHYMH7jo/9amWzT8E MIME-Version: 1.0 X-Received: by 10.194.175.202 with SMTP id cc10mr197152wjc.48.1384026647549; Sat, 09 Nov 2013 11:50:47 -0800 (PST) Received: by 10.216.73.198 with HTTP; Sat, 9 Nov 2013 11:50:47 -0800 (PST) In-Reply-To: References: <527AB482.80600@earthlink.net> <87ppqd1a0t.fsf@fleche.redhat.com> <87r4asz3be.fsf@fleche.redhat.com> Date: Sat, 09 Nov 2013 19:55:00 -0000 Message-ID: Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c From: Doug Evans To: Tom Tromey Cc: Stan Shebs , gdb-patches@sourceware.org, xdje42@gmail.com Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-11/txt/msg00260.txt.bz2 WTF? Where'd the patch go? Let's try this again. On Sat, Nov 9, 2013 at 11:47 AM, Doug Evans wrote: > On Thu, Nov 7, 2013 at 8:40 AM, Doug Evans wrote: >> On Thu, Nov 7, 2013 at 6:36 AM, Tom Tromey wrote: >>>>>>>> "Doug" == Doug Evans writes: >>> >>> Doug> Tom Tromey writes: >>> Stan> +/* A helper function for tyscm_richcompare that checks two types for >>> Stan> + "deep" equality. Returns non-zero if the types are considered the >>> Stan> + same, zero otherwise. */ >>>>> >>> Stan> "tyscm_richcompare"? Should that be typy_... ? >>>>> >>>>> It would be helpful if Doug could list all the change he made when >>>>> moving the code. >>> >>> Doug> I don't understand. >>> Doug> Which changes? While useful beyond its present state, this is in >>> Doug> essence just a cleanup. >>> >>> I had thought this patch was more or less a straight move of the code. >>> But Stan's note revealed a change from what is currently in the tree. >>> So the question is, can you say what else changed? >>> That would be handy so I don't have to go over it line-by-line myself. >> >> Ah. Except for the comment (*1) the only substantive change is in the result: >> Py_{NE,EQ} -> 0.1. >> >> (*1): Early on I made a copy because I wasn't sure how things would end up, >> and left in a FIXME to remind myself to revisit. >> I revisited and realized there's no need for the copy, but missed the >> comment. Blech. >> "diff -b before after" shows nothing of note to me. > > Here's v2 of the patch. > > I fixed the comment and added an assert to check type1,type2 != NULL. > > I changed the email address in the ChangeLog entry 'cus I'm having > problems with this domain. > After this email hopefully the switchover is complete.