Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Patrick Palka <patrick@parcs.ath.cx>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Asynchronously resize the TUI
Date: Thu, 19 Feb 2015 00:04:00 -0000	[thread overview]
Message-ID: <CA+C-WL9zh2KyViH8Hxf6G=9AuppfYGNYeaWHLBc8KiBiPj4Xwg@mail.gmail.com> (raw)
In-Reply-To: <54E4629A.5050400@redhat.com>

On Wed, Feb 18, 2015 at 4:59 AM, Pedro Alves <palves@redhat.com> wrote:
> On 02/18/2015 12:36 AM, Patrick Palka wrote:
>
>> gdb/ChangeLog:
>>
>>       * tui/tui-io.c (tui_handle_resize_during_io): Remove this
>>       function.
>>       (tui_putc): Don't call tui_handle_resize_during_io.
>>       (tui_getc): Likewise.
>>       (tui_mld_getc): Likewise.
>>       * tui/tui-win.c: Include event-loop.h and tui/tui-io.h.
>>       (tui_sigwinch_token): New static variable.
>>       (tui_initialize_win): Adjust documentation.  Set
>>       tui_sigwinch_token.
>>       (tui_async_resize_screen): New asynchronous callback.
>>       (tui_sigwinch_handler): Adjust documentation.  Asynchronously
>>       invoke tui_async_resize_screen.
>
>
> OK.  Thanks for doing this!

Thanks for reviewing.  I have committed the patch in two pieces
because I forgot to add the gdb/ChangeLog entry in the first commit.
Sorry about that...

BTW shouldn't the object returned by create_async_signal_handler() be
eventually deallocated via delete_async_event_handler() at some point?
 It doesn't seem that we do this for any async signal handler
currently in use so far..

>
> Thanks,
> Pedro Alves
>


  reply	other threads:[~2015-02-19  0:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18  0:36 Patrick Palka
2015-02-18 10:00 ` Pedro Alves
2015-02-19  0:04   ` Patrick Palka [this message]
2015-02-19 11:00     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+C-WL9zh2KyViH8Hxf6G=9AuppfYGNYeaWHLBc8KiBiPj4Xwg@mail.gmail.com' \
    --to=patrick@parcs.ath.cx \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox