From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23536 invoked by alias); 19 Feb 2015 00:04:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23517 invoked by uid 89); 19 Feb 2015 00:04:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-pd0-f178.google.com Received: from mail-pd0-f178.google.com (HELO mail-pd0-f178.google.com) (209.85.192.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 19 Feb 2015 00:04:01 +0000 Received: by pdjg10 with SMTP id g10so4809071pdj.1 for ; Wed, 18 Feb 2015 16:04:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=tikraFjx9BFFlqunKSTqbjaaVtQZj/vUf1aFLJgKx3o=; b=B47RktOsDZGuY66nVW2i5uV/CUAoCyAxIRZh7ToekSgUp7nq/Es0+akT4oz/Y6/XlH zQ5LGPV6oTGuEhKqbjBARwyy1IcQSEoELry8qTfsYeWiKit9W81Z/xZUZBF+foxy0t6e PIUv5hppESAjhHwoXFXHFmBxEeqsoCMt7l/Z12UuGueBKbX3aKSgLgCP0b5HuUvPWUp+ opx5whSl+w5oIFpgKwc66ovG1Yc7R4xg9OSiPXJZgZUyS899+gP+pGdV4Sx1sptTMXFd zP2amiN3QrGtSxC1OthXCjqKPzwhrO/Hqz/p4gqUaHe7Qw2SqTWz0vjmgUVUhluTxdDp Yfag== X-Gm-Message-State: ALoCoQnLM7Tbxna4W+K8HfAHGPX4Z53fmW02W1P+pNzAKlEMFQAaIh/JZVobqu1ol3vNT24cAAbk X-Received: by 10.70.126.225 with SMTP id nb1mr3175943pdb.40.1424304239951; Wed, 18 Feb 2015 16:03:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.70.127.195 with HTTP; Wed, 18 Feb 2015 16:03:39 -0800 (PST) In-Reply-To: <54E4629A.5050400@redhat.com> References: <1424219777-12138-1-git-send-email-patrick@parcs.ath.cx> <54E4629A.5050400@redhat.com> From: Patrick Palka Date: Thu, 19 Feb 2015 00:04:00 -0000 Message-ID: Subject: Re: [PATCH] Asynchronously resize the TUI To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-02/txt/msg00507.txt.bz2 On Wed, Feb 18, 2015 at 4:59 AM, Pedro Alves wrote: > On 02/18/2015 12:36 AM, Patrick Palka wrote: > >> gdb/ChangeLog: >> >> * tui/tui-io.c (tui_handle_resize_during_io): Remove this >> function. >> (tui_putc): Don't call tui_handle_resize_during_io. >> (tui_getc): Likewise. >> (tui_mld_getc): Likewise. >> * tui/tui-win.c: Include event-loop.h and tui/tui-io.h. >> (tui_sigwinch_token): New static variable. >> (tui_initialize_win): Adjust documentation. Set >> tui_sigwinch_token. >> (tui_async_resize_screen): New asynchronous callback. >> (tui_sigwinch_handler): Adjust documentation. Asynchronously >> invoke tui_async_resize_screen. > > > OK. Thanks for doing this! Thanks for reviewing. I have committed the patch in two pieces because I forgot to add the gdb/ChangeLog entry in the first commit. Sorry about that... BTW shouldn't the object returned by create_async_signal_handler() be eventually deallocated via delete_async_event_handler() at some point? It doesn't seem that we do this for any async signal handler currently in use so far.. > > Thanks, > Pedro Alves >