From: Pedro Alves <palves@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Asynchronously resize the TUI
Date: Thu, 19 Feb 2015 11:00:00 -0000 [thread overview]
Message-ID: <54E5C240.2020801@redhat.com> (raw)
In-Reply-To: <CA+C-WL9zh2KyViH8Hxf6G=9AuppfYGNYeaWHLBc8KiBiPj4Xwg@mail.gmail.com>
On 02/19/2015 12:03 AM, Patrick Palka wrote:
> Thanks for reviewing. I have committed the patch in two pieces
> because I forgot to add the gdb/ChangeLog entry in the first commit.
> Sorry about that...
No worries.
> BTW shouldn't the object returned by create_async_signal_handler() be
> eventually deallocated via delete_async_event_handler() at some point?
> It doesn't seem that we do this for any async signal handler
> currently in use so far..
Yeah, that's not really different from all the global objects that
are allocated on the heap, and aren't ever deleted. They'll just go away
when GDB exits along with the heap. For a proper GDB-as-a-library use
case though, we'd/we'll probably need to consider this.
Thanks,
Pedro Alves
prev parent reply other threads:[~2015-02-19 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 0:36 Patrick Palka
2015-02-18 10:00 ` Pedro Alves
2015-02-19 0:04 ` Patrick Palka
2015-02-19 11:00 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E5C240.2020801@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox