Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: Will Newton <will.newton@linaro.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
		"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH/AARCH64] Fix hardware break points
Date: Thu, 12 Sep 2013 07:15:00 -0000	[thread overview]
Message-ID: <CA+=Sn1kwQNtXFU6EA5X90934qeRGSS8Ryb9DZTbOb9PVoX++5w@mail.gmail.com> (raw)
In-Reply-To: <CANu=DmjNqWDGFQY9bB9KbY0L1U6eJ58CooAQoOinGsCZikM5yA@mail.gmail.com>

On Tue, Sep 10, 2013 at 7:37 AM, Will Newton <will.newton@linaro.org> wrote:
> On 27 July 2013 23:42, Andrew Pinski <pinskia@gmail.com> wrote:
>
> Hi Andrew,
>
>> On Sat, Jul 27, 2013 at 2:34 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> Andrew Pinski <pinskia@gmail.com> writes:
>>>
>>>> OK?  Built and tested on aarch64-linux-gnu with no regressions.
>>>
>>> Did you?
>>>
>>>> +  memset (&regs, 0, size(regs));
>>
>> This is what I get for copying and pasting from one source file to another.
>>
>> Here is the fixed one which was definitely tested.
>
> What's the status of this patch? It seems like it fixes real problems
> people are seeing in the field.


After not much thought, I decided this was an obvious patch as regs is
used uninitialized otherwise when passed to ptrace.

Committed now.

Thanks,
Andrew Pinski

>
> Thanks,
>
> --
> Will Newton
> Toolchain Working Group, Linaro


  reply	other threads:[~2013-09-12  7:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-27 20:13 Andrew Pinski
2013-07-27 21:34 ` Andreas Schwab
2013-07-27 22:42   ` Andrew Pinski
2013-07-29 17:56     ` Tom Tromey
2013-09-10 14:38     ` Will Newton
2013-09-12  7:15       ` Andrew Pinski [this message]
2013-09-16 12:44         ` Pedro Alves
2013-09-16 12:53           ` Will Newton
2013-09-16 13:38             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1kwQNtXFU6EA5X90934qeRGSS8Ryb9DZTbOb9PVoX++5w@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=will.newton@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox