From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105225-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10829 invoked by alias); 12 Sep 2013 07:15:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10814 invoked by uid 89); 12 Sep 2013 07:15:57 -0000
Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 12 Sep 2013 07:15:57 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2
X-HELO: mail-wg0-f43.google.com
Received: by mail-wg0-f43.google.com with SMTP id z12so8885562wgg.10        for <gdb-patches@sourceware.org>; Thu, 12 Sep 2013 00:15:54 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.180.11.239 with SMTP id t15mr4668780wib.4.1378970154231; Thu, 12 Sep 2013 00:15:54 -0700 (PDT)
Received: by 10.217.119.193 with HTTP; Thu, 12 Sep 2013 00:15:54 -0700 (PDT)
In-Reply-To: <CANu=DmjNqWDGFQY9bB9KbY0L1U6eJ58CooAQoOinGsCZikM5yA@mail.gmail.com>
References: <CA+=Sn1mFs3=aY70af9xWomP-t6-kfsgzXr83xRBuXdofoZVMsQ@mail.gmail.com>	<87k3kbbsbz.fsf@igel.home>	<CA+=Sn1k=30-Y=MFEq3gVcDR9xugWsMWpHi8_a79hCUX6vxjEEw@mail.gmail.com>	<CANu=DmjNqWDGFQY9bB9KbY0L1U6eJ58CooAQoOinGsCZikM5yA@mail.gmail.com>
Date: Thu, 12 Sep 2013 07:15:00 -0000
Message-ID: <CA+=Sn1kwQNtXFU6EA5X90934qeRGSS8Ryb9DZTbOb9PVoX++5w@mail.gmail.com>
Subject: Re: [PATCH/AARCH64] Fix hardware break points
From: Andrew Pinski <pinskia@gmail.com>
To: Will Newton <will.newton@linaro.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg00370.txt.bz2

On Tue, Sep 10, 2013 at 7:37 AM, Will Newton <will.newton@linaro.org> wrote:
> On 27 July 2013 23:42, Andrew Pinski <pinskia@gmail.com> wrote:
>
> Hi Andrew,
>
>> On Sat, Jul 27, 2013 at 2:34 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> Andrew Pinski <pinskia@gmail.com> writes:
>>>
>>>> OK?  Built and tested on aarch64-linux-gnu with no regressions.
>>>
>>> Did you?
>>>
>>>> +  memset (&regs, 0, size(regs));
>>
>> This is what I get for copying and pasting from one source file to another.
>>
>> Here is the fixed one which was definitely tested.
>
> What's the status of this patch? It seems like it fixes real problems
> people are seeing in the field.


After not much thought, I decided this was an obvious patch as regs is
used uninitialized otherwise when passed to ptrace.

Committed now.

Thanks,
Andrew Pinski

>
> Thanks,
>
> --
> Will Newton
> Toolchain Working Group, Linaro