Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH/AARCH64] Fix hardware break points
Date: Sat, 27 Jul 2013 22:42:00 -0000	[thread overview]
Message-ID: <CA+=Sn1k=30-Y=MFEq3gVcDR9xugWsMWpHi8_a79hCUX6vxjEEw@mail.gmail.com> (raw)
In-Reply-To: <87k3kbbsbz.fsf@igel.home>

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

On Sat, Jul 27, 2013 at 2:34 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Andrew Pinski <pinskia@gmail.com> writes:
>
>> OK?  Built and tested on aarch64-linux-gnu with no regressions.
>
> Did you?
>
>> +  memset (&regs, 0, size(regs));

This is what I get for copying and pasting from one source file to another.

Here is the fixed one which was definitely tested.

Thanks,
Andrew Pinski

>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."

[-- Attachment #2: fixfork.diff.txt --]
[-- Type: text/plain, Size: 633 bytes --]

? gdb/.aarch64-linux-nat.c.swp
Index: gdb/aarch64-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/aarch64-linux-nat.c,v
retrieving revision 1.4
diff -u -p -r1.4 aarch64-linux-nat.c
--- gdb/aarch64-linux-nat.c	14 Feb 2013 13:50:30 -0000	1.4
+++ gdb/aarch64-linux-nat.c	27 Jul 2013 22:42:18 -0000
@@ -312,6 +312,7 @@ aarch64_linux_set_debug_regs (const stru
   const CORE_ADDR *addr;
   const unsigned int *ctrl;
 
+  memset (&regs, 0, sizeof (regs));
   iov.iov_base = &regs;
   iov.iov_len = sizeof (regs);
   count = watchpoint ? aarch64_num_wp_regs : aarch64_num_bp_regs;

  reply	other threads:[~2013-07-27 22:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-27 20:13 Andrew Pinski
2013-07-27 21:34 ` Andreas Schwab
2013-07-27 22:42   ` Andrew Pinski [this message]
2013-07-29 17:56     ` Tom Tromey
2013-09-10 14:38     ` Will Newton
2013-09-12  7:15       ` Andrew Pinski
2013-09-16 12:44         ` Pedro Alves
2013-09-16 12:53           ` Will Newton
2013-09-16 13:38             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1k=30-Y=MFEq3gVcDR9xugWsMWpHi8_a79hCUX6vxjEEw@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox