From: Tristan Gingold <gingold@adacore.com>
To: Josh Matthews <josh@joshmatthews.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Darwin build fix for unused prototypes
Date: Fri, 09 Mar 2012 08:41:00 -0000 [thread overview]
Message-ID: <C19B4E31-1202-4B60-B890-B9CFA73AD998@adacore.com> (raw)
In-Reply-To: <CAOvJiVVT4_Gqw==81sT0bQ5MLfWiZ6ROMqjZRKrsqp2XtZU9_Q@mail.gmail.com>
On Mar 8, 2012, at 7:36 PM, Josh Matthews wrote:
> 2012-03-08 Josh Matthews <josh@joshmatthews.net>
>
> * darwin-nat-info.c: Add missing prototype for
> _initialize_darwin_info_commands. Make darwin_debug_port_info static.
> * darwin-nat.c: Add missing prototype for _initialize_darwin_infereior.
> * i386-darwin-nat.c: Remove unused functions
> i386_darwin_dr_set, i386_darwin_dr_get, i386_darwin_set_control,
> i386_darwin_get_control, i386_darwin_dr_set_addr,
> i386_darwin_get_addr, i386_darwin_get_status, i386_darwin_get_control.
> * machoread.c: Add missing prototype for _initialize_machoread.
> <darwin_prototypes.diff>
Hi Josh,
the 'add missing prototype' parts are OK. Please commit (if you have commit rights) or tell me if I have to do so.
I'd prefer to keep the i386-darwin-nat.c functions that deal with hardware watchpoint, although I still have to enable this.
Maybe a temporary '#ifdef HW_WATCHPOINT_NOT_YET_ENABLED' would be better in this case.
Tristan.
next prev parent reply other threads:[~2012-03-09 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 18:37 Josh Matthews
2012-03-09 8:41 ` Tristan Gingold [this message]
2012-03-09 13:40 ` Joel Brobecker
2012-03-09 15:40 ` Josh Matthews
2012-03-09 16:35 ` Joel Brobecker
2012-03-09 17:22 ` Josh Matthews
2012-03-14 1:48 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C19B4E31-1202-4B60-B890-B9CFA73AD998@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=josh@joshmatthews.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox