From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88702-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16278 invoked by alias); 9 Mar 2012 08:41:50 -0000
Received: (qmail 16269 invoked by uid 22791); 9 Mar 2012 08:41:50 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 08:41:36 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 2EB3329006C;	Fri,  9 Mar 2012 09:41:36 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id x5nhtY64cz9a; Fri,  9 Mar 2012 09:41:36 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id 1B2B0290026;	Fri,  9 Mar 2012 09:41:35 +0100 (CET)
Subject: Re: [patch] Darwin build fix for unused prototypes
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: text/plain; charset=iso-8859-1
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <CAOvJiVVT4_Gqw==81sT0bQ5MLfWiZ6ROMqjZRKrsqp2XtZU9_Q@mail.gmail.com>
Date: Fri, 09 Mar 2012 08:41:00 -0000
Cc: gdb-patches@sourceware.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C19B4E31-1202-4B60-B890-B9CFA73AD998@adacore.com>
References: <CAOvJiVVT4_Gqw==81sT0bQ5MLfWiZ6ROMqjZRKrsqp2XtZU9_Q@mail.gmail.com>
To: Josh Matthews <josh@joshmatthews.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00324.txt.bz2


On Mar 8, 2012, at 7:36 PM, Josh Matthews wrote:

> 2012-03-08  Josh Matthews  <josh@joshmatthews.net>
>=20
>        * darwin-nat-info.c: Add missing prototype for
> _initialize_darwin_info_commands. Make darwin_debug_port_info static.
>        * darwin-nat.c: Add missing prototype for _initialize_darwin_infer=
eior.
>        * i386-darwin-nat.c: Remove unused functions
> i386_darwin_dr_set, i386_darwin_dr_get, i386_darwin_set_control,
> i386_darwin_get_control, i386_darwin_dr_set_addr,
> i386_darwin_get_addr, i386_darwin_get_status, i386_darwin_get_control.
>        * machoread.c: Add missing prototype for _initialize_machoread.
> <darwin_prototypes.diff>

Hi Josh,

the 'add missing prototype' parts are OK.  Please commit (if you have commi=
t rights) or tell me if I have to do so.

I'd prefer to keep the i386-darwin-nat.c functions that deal with hardware =
watchpoint, although I still have to enable this.
Maybe a temporary '#ifdef HW_WATCHPOINT_NOT_YET_ENABLED' would be better in=
 this case.

Tristan.