Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Josh Matthews <josh@joshmatthews.net>
Cc: gdb-patches@sourceware.org, Tristan Gingold <gingold@adacore.com>
Subject: Re: [patch] Darwin build fix for unused prototypes
Date: Wed, 14 Mar 2012 01:48:00 -0000	[thread overview]
Message-ID: <20120314014833.GC2853@adacore.com> (raw)
In-Reply-To: <CAOvJiVVmhrw3hE6Dw1EacqFCVa9JgvJ46L4Rog8QmiiT9fSxJQ@mail.gmail.com>

> I lost the copyright assignment form and haven't been able to find it,
> unfortunately. Since I'm now able to print it and send it myself, I'll
> do that, but I don't think it's worth holding up this change for the
> form. I have aspirations of fixing the problem that prevents gdb from
> being able to debug Firefox, but that's been fruitless for me so far.

You are quite right. The patch is sufficiently small and obvious to
be accepted without a formal assignment.

> >> gdb/ChangeLog:
> >>
> >>       * darwin-nat-info.c (_initialize_darwin_info_commands): Add
> >>       prototype.
> >>       (darwin_debug_port_info): Make static.
> >>       * darwin-nat.c (_initialize_darwin_inferior): Add prototype.
> >>       * machoread.c (_initialize_machoread): Add prototype.
> >>       * i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr_get)
> >>       (i386_darwin_set_control, i386_darwin_get_control)
> >>       i386_darwin_dr_set_addr, i386_darwin_get_addr)
> >>       i386_darwin_get_status, i386_darwin_get_control):
> >>       Hide these with HW_WATCHPOINT_NOT_YET_ENABLED.

Now applied. Sorry for the delay, it's been pretty busy for me
the last few days...

-- 
Joel


      reply	other threads:[~2012-03-14  1:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 18:37 Josh Matthews
2012-03-09  8:41 ` Tristan Gingold
2012-03-09 13:40 ` Joel Brobecker
2012-03-09 15:40   ` Josh Matthews
2012-03-09 16:35     ` Joel Brobecker
2012-03-09 17:22       ` Josh Matthews
2012-03-14  1:48         ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120314014833.GC2853@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    --cc=josh@joshmatthews.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox