From: Tristan Gingold <gingold@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: RFA: [Ada] extract known tasks array parameters from symbol table
Date: Thu, 23 Feb 2012 16:34:00 -0000 [thread overview]
Message-ID: <C0E6EE41-405B-4055-B00E-DB2E5C7222F3@adacore.com> (raw)
In-Reply-To: <20120221170740.GH2692@adacore.com>
On Feb 21, 2012, at 6:07 PM, Joel Brobecker wrote:
>> In fact it wasn't that good. Leads to crash in case the symbol was
>> LOC_UNRESOLVED. It is therefore better to use the minsymtab to get
>> the address. Here is the new version.
>
> Ah - Ugh!
>
>> 2012-02-13 Tristan Gingold <gingold@adacore.com>
>>
>> * ada-tasks.c (struct ada_tasks_inferior_data): Add
>> known_tasks_element and known_tasks_length fields.
>> (read_known_tasks_array): Change argument type. Use pointer type
>> and number of elements from DATA. Adjust.
>> (read_known_tasks_list): Likewise.
>> (get_known_tasks_addr): Remove.
>> (ada_set_current_inferior_known_tasks_addr): Renamed to ...
>> (ada_tasks_inferior_data_sniffer): ... this. Use symtab for element
>> type and array length. Merge former get_known_tasks_addr code.
>
> This one looks good to me. Thanks!
Now committed.
Thanks,
Tristan.
prev parent reply other threads:[~2012-02-23 11:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 15:14 Tristan Gingold
2012-02-13 16:16 ` Joel Brobecker
2012-02-14 8:19 ` Tristan Gingold
2012-02-14 15:47 ` Joel Brobecker
2012-02-16 14:40 ` Tristan Gingold
2012-02-16 17:19 ` Joel Brobecker
2012-02-17 16:34 ` Tristan Gingold
2012-02-17 16:37 ` Joel Brobecker
2012-02-17 19:23 ` Tristan Gingold
2012-02-20 17:11 ` Tristan Gingold
2012-02-21 18:16 ` Joel Brobecker
2012-02-23 16:34 ` Tristan Gingold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0E6EE41-405B-4055-B00E-DB2E5C7222F3@adacore.com \
--to=gingold@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox