From: Joel Brobecker <brobecker@adacore.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: RFA: [Ada] extract known tasks array parameters from symbol table
Date: Thu, 16 Feb 2012 17:19:00 -0000 [thread overview]
Message-ID: <20120216171547.GD14803@adacore.com> (raw)
In-Reply-To: <5F4AB963-E82C-4206-B479-E46311CDABB0@adacore.com>
> here is the new version, taking into account your comments: I have
> mostly reshaped ada_set_current_inferior_known_tasks_addr, tell me if
> the new form is ok (and then I will test it more thoroughly).
Overall, that looks good to me. I see what you mean in terms of
supporting the stripped runtime (this near duplication is ugly),
but I don't see an efficient way to avoid it.
Just one minor comment:
> @@ -865,27 +848,95 @@ get_known_tasks_addr (const char *name)
> static void
> ada_set_current_inferior_known_tasks_addr (struct ada_tasks_inferior_data *data)
I would change the name of the function since it's doing more and more
than just setting the address. Something like "set_ada_tasks_inferior_data"
for instance, or maybe "ada_tasks_inferior_data_sniffer", etc.
Can you also update the comment to just say that it sets all fields in
DATA instead of specifying each one? It's a bit more vague, but still
true nonetheless, and will avoid having to update the comment if we add
new fields again in the future.
Thank you!
--
Joel
next prev parent reply other threads:[~2012-02-16 17:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 15:14 Tristan Gingold
2012-02-13 16:16 ` Joel Brobecker
2012-02-14 8:19 ` Tristan Gingold
2012-02-14 15:47 ` Joel Brobecker
2012-02-16 14:40 ` Tristan Gingold
2012-02-16 17:19 ` Joel Brobecker [this message]
2012-02-17 16:34 ` Tristan Gingold
2012-02-17 16:37 ` Joel Brobecker
2012-02-17 19:23 ` Tristan Gingold
2012-02-20 17:11 ` Tristan Gingold
2012-02-21 18:16 ` Joel Brobecker
2012-02-23 16:34 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216171547.GD14803@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox