From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88134-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28534 invoked by alias); 23 Feb 2012 11:18:41 -0000
Received: (qmail 28525 invoked by uid 22791); 23 Feb 2012 11:18:40 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Feb 2012 11:18:27 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 364E929004C;	Thu, 23 Feb 2012 12:18:27 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id BCs1ElfzbKKM; Thu, 23 Feb 2012 12:18:27 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id 258CE290011;	Thu, 23 Feb 2012 12:18:27 +0100 (CET)
Subject: Re: RFA: [Ada] extract known tasks array parameters from symbol table
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <20120221170740.GH2692@adacore.com>
Date: Thu, 23 Feb 2012 16:34:00 -0000
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Content-Transfer-Encoding: 7bit
Message-Id: <C0E6EE41-405B-4055-B00E-DB2E5C7222F3@adacore.com>
References: <7A06C670-A574-4AE4-A89C-2532671E5F64@adacore.com> <20120213161529.GE3474@adacore.com> <5F4AB963-E82C-4206-B479-E46311CDABB0@adacore.com> <20120216171547.GD14803@adacore.com> <D09C6752-1B6F-461E-9D79-6919A4134D58@adacore.com> <20120217163434.GF14803@adacore.com> <54477479-8A1C-4EC2-BE78-E790828EDD5E@adacore.com> <20120221170740.GH2692@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00506.txt.bz2


On Feb 21, 2012, at 6:07 PM, Joel Brobecker wrote:

>> In fact it wasn't that good.  Leads to crash in case the symbol was
>> LOC_UNRESOLVED.  It is therefore better to use the minsymtab to get
>> the address.  Here is the new version.
> 
> Ah - Ugh!
> 
>> 2012-02-13  Tristan Gingold  <gingold@adacore.com>
>> 
>> 	* ada-tasks.c (struct ada_tasks_inferior_data): Add
>> 	known_tasks_element and known_tasks_length fields.
>> 	(read_known_tasks_array): Change argument type.  Use pointer type
>> 	and number of elements from DATA.  Adjust.
>> 	(read_known_tasks_list): Likewise.
>> 	(get_known_tasks_addr): Remove.
>> 	(ada_set_current_inferior_known_tasks_addr): Renamed to ...
>> 	(ada_tasks_inferior_data_sniffer): ... this.  Use symtab for element
>> 	type and array length.  Merge former get_known_tasks_addr code.
> 
> This one looks good to me. Thanks!

Now committed.

Thanks,
Tristan.