Current master fails to build on i686-pc-linux-gnu

Current master fails to build on i686-pc-linux-gnu

[Ruslan Kabatsayev]

Hello,

Building current master of binutils-gdb (commit ebd1c6d1d30; git-blame
points to commits e35000a7f8be and d0922fcf02c6) results in some
-Werror=format= errors on i686-pc-linux-gnu:

In file included from dwarf2read.c:47:0:
dwarf2read.c: In function ‘bool is_valid_DW_AT_defaulted(ULONGEST)’:
complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
unsigned int}’ [-Werror=format=]
  complaint_internal (FMT, ##__VA_ARGS__);  \
                                        ^
dwarf2read.c:15490:3: note: in expansion of macro ‘complaint’
   complaint (_("unrecognized DW_AT_defaulted value (%lu)"), value);
   ^~~~~~~~~
dwarf2read.c: In function ‘bool
is_valid_DW_AT_calling_convention_for_type(ULONGEST)’:
complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
unsigned int}’ [-Werror=format=]
  complaint_internal (FMT, ##__VA_ARGS__);  \
                                        ^
dwarf2read.c:15869:7: note: in expansion of macro ‘complaint’
       complaint (_("unrecognized DW_AT_calling_convention value "
       ^~~~~~~~~
dwarf2read.c: In function ‘bool
is_valid_DW_AT_calling_convention_for_subroutine(ULONGEST)’:
complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
unsigned int}’ [-Werror=format=]
  complaint_internal (FMT, ##__VA_ARGS__);  \
                                        ^
dwarf2read.c:15895:7: note: in expansion of macro ‘complaint’
       complaint (_("unrecognized DW_AT_calling_convention value "
       ^~~~~~~~~

Regards,
Ruslan

Re: Current master fails to build on i686-pc-linux-gnu

[Simon Marchi]

On 2019-12-24 3:44 p.m., Ruslan Kabatsayev wrote:
> Hello,
> 
> Building current master of binutils-gdb (commit ebd1c6d1d30; git-blame
> points to commits e35000a7f8be and d0922fcf02c6) results in some
> -Werror=format= errors on i686-pc-linux-gnu:
> 
> In file included from dwarf2read.c:47:0:
> dwarf2read.c: In function ‘bool is_valid_DW_AT_defaulted(ULONGEST)’:
> complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> unsigned int}’ [-Werror=format=]
>   complaint_internal (FMT, ##__VA_ARGS__);  \
>                                         ^
> dwarf2read.c:15490:3: note: in expansion of macro ‘complaint’
>    complaint (_("unrecognized DW_AT_defaulted value (%lu)"), value);
>    ^~~~~~~~~
> dwarf2read.c: In function ‘bool
> is_valid_DW_AT_calling_convention_for_type(ULONGEST)’:
> complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> unsigned int}’ [-Werror=format=]
>   complaint_internal (FMT, ##__VA_ARGS__);  \
>                                         ^
> dwarf2read.c:15869:7: note: in expansion of macro ‘complaint’
>        complaint (_("unrecognized DW_AT_calling_convention value "
>        ^~~~~~~~~
> dwarf2read.c: In function ‘bool
> is_valid_DW_AT_calling_convention_for_subroutine(ULONGEST)’:
> complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> unsigned int}’ [-Werror=format=]
>   complaint_internal (FMT, ##__VA_ARGS__);  \
>                                         ^
> dwarf2read.c:15895:7: note: in expansion of macro ‘complaint’
>        complaint (_("unrecognized DW_AT_calling_convention value "
>        ^~~~~~~~~
> 
> Regards,
> Ruslan

Sorry about that, I failed to catch it during review.  The fix is simple,
these should use pulongest (value) with the format specifier "%s".  I don't
really have time right now to fix it.  If you'd like to make a patch, please
go ahead and push it.

Simon

Re: Current master fails to build on i686-pc-linux-gnu

[Ruslan Kabatsayev]

On Wed, 25 Dec 2019 at 00:51, Simon Marchi <simark@simark.ca> wrote:
>
> On 2019-12-24 3:44 p.m., Ruslan Kabatsayev wrote:
> > Hello,
> >
> > Building current master of binutils-gdb (commit ebd1c6d1d30; git-blame
> > points to commits e35000a7f8be and d0922fcf02c6) results in some
> > -Werror=format= errors on i686-pc-linux-gnu:
> >
> > In file included from dwarf2read.c:47:0:
> > dwarf2read.c: In function ‘bool is_valid_DW_AT_defaulted(ULONGEST)’:
> > complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> > unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> > unsigned int}’ [-Werror=format=]
> >   complaint_internal (FMT, ##__VA_ARGS__);  \
> >                                         ^
> > dwarf2read.c:15490:3: note: in expansion of macro ‘complaint’
> >    complaint (_("unrecognized DW_AT_defaulted value (%lu)"), value);
> >    ^~~~~~~~~
> > dwarf2read.c: In function ‘bool
> > is_valid_DW_AT_calling_convention_for_type(ULONGEST)’:
> > complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> > unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> > unsigned int}’ [-Werror=format=]
> >   complaint_internal (FMT, ##__VA_ARGS__);  \
> >                                         ^
> > dwarf2read.c:15869:7: note: in expansion of macro ‘complaint’
> >        complaint (_("unrecognized DW_AT_calling_convention value "
> >        ^~~~~~~~~
> > dwarf2read.c: In function ‘bool
> > is_valid_DW_AT_calling_convention_for_subroutine(ULONGEST)’:
> > complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> > unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> > unsigned int}’ [-Werror=format=]
> >   complaint_internal (FMT, ##__VA_ARGS__);  \
> >                                         ^
> > dwarf2read.c:15895:7: note: in expansion of macro ‘complaint’
> >        complaint (_("unrecognized DW_AT_calling_convention value "
> >        ^~~~~~~~~
> >
> > Regards,
> > Ruslan
>
> Sorry about that, I failed to catch it during review.  The fix is simple,
> these should use pulongest (value) with the format specifier "%s".  I don't
> really have time right now to fix it.  If you'd like to make a patch, please
> go ahead and push it.

OK, pushed 3142e908d01.

>
> Simon
>

Regards,
Ruslan

Re: Current master fails to build on i686-pc-linux-gnu

[Simon Marchi]

On 2019-12-25 4:15 p.m., Ruslan Kabatsayev wrote:
> OK, pushed 3142e908d01.

Thanks!

Simon

RE: Current master fails to build on i686-pc-linux-gnu

[Aktemur, Tankut Baris]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2991 bytes --]

* On Wednesday, December 25, 2019 10:15 PM, Ruslan Kabatsayev wrote:
> On Wed, 25 Dec 2019 at 00:51, Simon Marchi <simark@simark.ca> wrote:
> >
> > On 2019-12-24 3:44 p.m., Ruslan Kabatsayev wrote:
> > > Hello,
> > >
> > > Building current master of binutils-gdb (commit ebd1c6d1d30; git-blame
> > > points to commits e35000a7f8be and d0922fcf02c6) results in some
> > > -Werror=format= errors on i686-pc-linux-gnu:
> > >
> > > In file included from dwarf2read.c:47:0:
> > > dwarf2read.c: In function ‘bool is_valid_DW_AT_defaulted(ULONGEST)’:
> > > complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> > > unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> > > unsigned int}’ [-Werror=format=]
> > >   complaint_internal (FMT, ##__VA_ARGS__);  \
> > >                                         ^
> > > dwarf2read.c:15490:3: note: in expansion of macro ‘complaint’
> > >    complaint (_("unrecognized DW_AT_defaulted value (%lu)"), value);
> > >    ^~~~~~~~~
> > > dwarf2read.c: In function ‘bool
> > > is_valid_DW_AT_calling_convention_for_type(ULONGEST)’:
> > > complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> > > unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> > > unsigned int}’ [-Werror=format=]
> > >   complaint_internal (FMT, ##__VA_ARGS__);  \
> > >                                         ^
> > > dwarf2read.c:15869:7: note: in expansion of macro ‘complaint’
> > >        complaint (_("unrecognized DW_AT_calling_convention value "
> > >        ^~~~~~~~~
> > > dwarf2read.c: In function ‘bool
> > > is_valid_DW_AT_calling_convention_for_subroutine(ULONGEST)’:
> > > complaints.h:38:40: error: format ‘%lu’ expects argument of type ‘long
> > > unsigned int’, but argument 2 has type ‘ULONGEST {aka long long
> > > unsigned int}’ [-Werror=format=]
> > >   complaint_internal (FMT, ##__VA_ARGS__);  \
> > >                                         ^
> > > dwarf2read.c:15895:7: note: in expansion of macro ‘complaint’
> > >        complaint (_("unrecognized DW_AT_calling_convention value "
> > >        ^~~~~~~~~
> > >
> > > Regards,
> > > Ruslan
> >
> > Sorry about that, I failed to catch it during review.  The fix is simple,
> > these should use pulongest (value) with the format specifier "%s".  I don't
> > really have time right now to fix it.  If you'd like to make a patch, please
> > go ahead and push it.
> 
> OK, pushed 3142e908d01.

Thanks for the fix, and sorry for the problem.

-Baris

> 
> >
> > Simon
> >
> 
> Regards,
> Ruslan

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
\x16º&Öéj×!zÊÞ¶êç×­ºß©b²Ö«r\x18\x1dn–­r\x17¬