From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21236 invoked by alias); 25 Dec 2019 21:16:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21073 invoked by uid 89); 25 Dec 2019 21:15:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy= X-HELO: mail-io1-f66.google.com Received: from mail-io1-f66.google.com (HELO mail-io1-f66.google.com) (209.85.166.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Dec 2019 21:15:38 +0000 Received: by mail-io1-f66.google.com with SMTP id k24so13152263ioc.4 for ; Wed, 25 Dec 2019 13:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l8hvki1vxtlN+mEn0oWXuq8Pw8Gh9PeB4j6tieEU0D8=; b=XCQ6b8sHt/9+RL37BnAEPLKusXp58PJU6aLIXXWqG1ygdMlIVYlnWVfbQOO0t9e4J7 e4TH38SkCtyZJ9MeWyTg5zeTN8strwYpmukOwhR6HL7n9GvEYrrq+MJmHKzJqskj9Og9 /q+yWP1kxViNBzcebwRtIwIUkZKmTeKwBTeZt7BSnPvRu/qT56/jbwOMe1myC391DVAV 1fiK0xCP7Ci5VKlpzkK1oSa975QJraTFpNw9N8xTH+ZnaBclfw56QNEJNmzfyAkaEY/n dA21jSkCDw5ddCI1oTwKqO4BxXfVFgLI0OmsoPKR7vhgC2+LfbpV+9t3/fU27OWyoq1c ISIA== MIME-Version: 1.0 References: <63b57288-985e-e09f-0449-e312b5cc6b62@simark.ca> In-Reply-To: <63b57288-985e-e09f-0449-e312b5cc6b62@simark.ca> From: Ruslan Kabatsayev Date: Wed, 25 Dec 2019 21:16:00 -0000 Message-ID: Subject: Re: Current master fails to build on i686-pc-linux-gnu To: Simon Marchi Cc: GDB Patches , tankut.baris.aktemur@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01009.txt.bz2 On Wed, 25 Dec 2019 at 00:51, Simon Marchi wrote: > > On 2019-12-24 3:44 p.m., Ruslan Kabatsayev wrote: > > Hello, > > > > Building current master of binutils-gdb (commit ebd1c6d1d30; git-blame > > points to commits e35000a7f8be and d0922fcf02c6) results in some > > -Werror=3Dformat=3D errors on i686-pc-linux-gnu: > > > > In file included from dwarf2read.c:47:0: > > dwarf2read.c: In function =E2=80=98bool is_valid_DW_AT_defaulted(ULONGE= ST)=E2=80=99: > > complaints.h:38:40: error: format =E2=80=98%lu=E2=80=99 expects argumen= t of type =E2=80=98long > > unsigned int=E2=80=99, but argument 2 has type =E2=80=98ULONGEST {aka l= ong long > > unsigned int}=E2=80=99 [-Werror=3Dformat=3D] > > complaint_internal (FMT, ##__VA_ARGS__); \ > > ^ > > dwarf2read.c:15490:3: note: in expansion of macro =E2=80=98complaint=E2= =80=99 > > complaint (_("unrecognized DW_AT_defaulted value (%lu)"), value); > > ^~~~~~~~~ > > dwarf2read.c: In function =E2=80=98bool > > is_valid_DW_AT_calling_convention_for_type(ULONGEST)=E2=80=99: > > complaints.h:38:40: error: format =E2=80=98%lu=E2=80=99 expects argumen= t of type =E2=80=98long > > unsigned int=E2=80=99, but argument 2 has type =E2=80=98ULONGEST {aka l= ong long > > unsigned int}=E2=80=99 [-Werror=3Dformat=3D] > > complaint_internal (FMT, ##__VA_ARGS__); \ > > ^ > > dwarf2read.c:15869:7: note: in expansion of macro =E2=80=98complaint=E2= =80=99 > > complaint (_("unrecognized DW_AT_calling_convention value " > > ^~~~~~~~~ > > dwarf2read.c: In function =E2=80=98bool > > is_valid_DW_AT_calling_convention_for_subroutine(ULONGEST)=E2=80=99: > > complaints.h:38:40: error: format =E2=80=98%lu=E2=80=99 expects argumen= t of type =E2=80=98long > > unsigned int=E2=80=99, but argument 2 has type =E2=80=98ULONGEST {aka l= ong long > > unsigned int}=E2=80=99 [-Werror=3Dformat=3D] > > complaint_internal (FMT, ##__VA_ARGS__); \ > > ^ > > dwarf2read.c:15895:7: note: in expansion of macro =E2=80=98complaint=E2= =80=99 > > complaint (_("unrecognized DW_AT_calling_convention value " > > ^~~~~~~~~ > > > > Regards, > > Ruslan > > Sorry about that, I failed to catch it during review. The fix is simple, > these should use pulongest (value) with the format specifier "%s". I don= 't > really have time right now to fix it. If you'd like to make a patch, ple= ase > go ahead and push it. OK, pushed 3142e908d01. > > Simon > Regards, Ruslan