RE: [PATCH] Avoid minimal language when DW_LANG_HIP is used.

["Cauble-Chantrenne, Allyson" <Allyson.Cauble-Chantrenne@amd.com>]

[AMD Official Use Only - AMD Internal Distribution Only]

Thank you for helping with my first binutils patch!

Till next time,

Allyson

-----Original Message-----
From: Simon Marchi <simark@simark.ca>
Sent: Friday, February 27, 2026 2:33 PM
To: Tom Tromey <tom@tromey.com>; Cauble-Chantrenne, Allyson <Allyson.Cauble-Chantrenne@amd.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid minimal language when DW_LANG_HIP is used.

[You don't often get email from simark@simark.ca. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On 2/18/26 1:39 PM, Tom Tromey wrote:
>>>>>> Allyson Cauble-Chantrenne <acaublec@amd.com> writes:
>
>> AMD clang is going to start using DW_LANG_HIP instead of
>> DW_LANG_C_plus_plus_14 (see PR at
>> https://github.com/llvm/llvm-project/pull/181738). Rather than
>> falling back to the minimal language, this commit ensures that GDB
>> will still treat it like a C++ app. The commit also adds a test to an
>> existing one.
>
> This looks good to me, thank you.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom

Allyson asked me off-list to push the patch, so I went ahead and did it.

I did a minor change, I tweaked the test prefix to just include the CU lang, since that's the unique aspect of each variant:

-    with_test_prefix $gdb_lang {
+    with_test_prefix $cu_lang {

Simon