From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +c8TIxXzoWnM5QwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 14:40:05 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=ZPbVw9e5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 74F391E0DD; Fri, 27 Feb 2026 14:40:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 276751E089 for ; Fri, 27 Feb 2026 14:40:04 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E23A04BA23EE for ; Fri, 27 Feb 2026 19:40:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E23A04BA23EE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=ZPbVw9e5 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011008.outbound.protection.outlook.com [40.107.208.8]) by sourceware.org (Postfix) with ESMTPS id DDB174B9DB4F for ; Fri, 27 Feb 2026 19:39:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DDB174B9DB4F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DDB174B9DB4F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.208.8 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1772221160; cv=pass; b=T23xpqczLQHq53D8JwMp+1Bhop4V+soT7KoFWlNIkr+pz2y/RNkrUiH1f5oFCTsPECcV2nhEKDsYs86h6AxB+21wNO+JQ0AapyJdhvcI2spkimX/CGbht+dHMr1Us5DTx/AWfdC8j4gNbq0ZRtXw1qCIOvMhjI8bo6PJCJpAmKI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1772221160; c=relaxed/simple; bh=b/ojM0tr5DRcQmYSbslFS/EHCqBGMAg9uSdBz0FiW8c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=mVhI24QnIkOTsOOhe1kS26EOlH5gjTpiq8GJ/LS9EEarzMCPBd+Ulq080aKMe0ZeBTX08cpWXAZuLoI1gv7Wfc8S1i+JPQtBVXkx3Mx/JwIAYz6I6aMh3V1IJVETs5oJJLHgndslxwfDnvsFq/QN2Ijt/dOgQsoM/htFNGz/lfk= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDB174B9DB4F ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iVydJ6Whk8fUpfCJOhSiEKr7gcs1lYGsUIfdg2u5yEDwMWNhdWTGR9vdBLIYcZeGF3N6nPktu7Rb3jX6Nlgi0S6PDcbZdsx+Y9Of2NR2G2IEmJxSYM8M1jZd5m+CtHCOPhAWJOLPYuqT3kHTaypgd09MN1VchpcDRiacOnOFyT2MH/YUozhCoQLUvLEr0ckQj1ErXY1nCfFnpqOyalrEwTB+WebqHPoIas6NEizuFWuXk3cqdFKN1Ib4Xtwd1cD9iG5COYGH6xO9mNxeaIvdyqAXlIsG8d0RZ2+ylql2qeFzS3eBwW3c7X7u0zjVHGmJF4ho45Wb4oT8Qmno0RRMoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=edJOWNXkatl03jA1Lev/fJXlbSoBhYanhwdjhvtRBj0=; b=OZ8b6EECfaQmMDzbu7m4Avx5vOT9xoRbPvdw80MM6DVqwlrkDM0JvuBJBUzyCZ5ejZW3XPf8w0uDg5R7jgJ+POLIMEfCNriYBuorEguI7uuLp1b/rvkbqmz9MoIPwJ6gne3aKM90K5PVbNALoBBafIl7ZPP1HIGxmIRo9w2Tx3mNSXVOqd6+nqj7bKsfm11lZRcPDxLRAGfir3NObYOHRQW90SMf7zt6dNrloZnaPHmREHkZprc7n34Hi8o2kZ0RWa2BgYrTknW2MIpkIGVKNB49PKtl4oMKKFpi3U6mtXcSomdo+VA+M3xHZs6CcaB2r8dblvF4mBupW/jnVxPZiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=edJOWNXkatl03jA1Lev/fJXlbSoBhYanhwdjhvtRBj0=; b=ZPbVw9e5j7K08oFoJiAHPHraY6NQMp3KQtfEfpeNIJEJw3+OxdZvpmNWObGIbEWL82os7rjXYwSTx8v/oW83U9l2En6pwxOBzHiDQYeJcVCcTm4zebzu8k0FlJrwEgKm/IvVeDDouTLt6LHGRoTmWuTTV3x24i3JVT3cZMliFnY= Received: from BN7PPF5D27497F1.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6d1) by DSWPR12MB999151.namprd12.prod.outlook.com (2603:10b6:8:36b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16; Fri, 27 Feb 2026 19:39:09 +0000 Received: from BN7PPF5D27497F1.namprd12.prod.outlook.com ([fe80::586:78c9:1829:dc22]) by BN7PPF5D27497F1.namprd12.prod.outlook.com ([fe80::586:78c9:1829:dc22%3]) with mapi id 15.20.9611.008; Fri, 27 Feb 2026 19:39:09 +0000 From: "Cauble-Chantrenne, Allyson" To: Simon Marchi , Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] Avoid minimal language when DW_LANG_HIP is used. Thread-Topic: [PATCH] Avoid minimal language when DW_LANG_HIP is used. Thread-Index: AQHcoEb6+/Nl/+sSa0SP6oSTWqin7rWIyztogA4z94CAAAEt4A== Date: Fri, 27 Feb 2026 19:39:09 +0000 Message-ID: References: <20260217195201.387306-1-acaublec@amd.com> <87o6ll7v74.fsf@tromey.com> <4988dcb0-06fd-4dbc-953c-d980cef42a63@simark.ca> In-Reply-To: <4988dcb0-06fd-4dbc-953c-d980cef42a63@simark.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=True; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2026-02-27T19:37:09.0000000Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=3; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PPF5D27497F1:EE_|DSWPR12MB999151:EE_ x-ms-office365-filtering-correlation-id: 682f363c-dfd5-4c1f-af77-08de7637e08f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|7053199007; x-microsoft-antispam-message-info: ixbokogb/ABl8ne9YUV8lw7prb+RTPw6npLTeuu9CNWhGxPlThFouwnGHiI/C/oQ3f0sF3HhpGVfOEbJHZka2pp0Rdq58Fw0GSI4F9sCuZruYp/biEb/gCU9ey98NBDnR3rpQ6xsKEDZoQnWqk0vE4tTTC20k64b4cJYhC05pwxwc8zKvilr4HHNPF9rEVmQ33tiDEp6UdCFo1gsgl9NtxoRWZDdiHLp+wCM8Z7Vca8Ns5DZik4xgyfBtMmC/WhLVryLgZ2TOZm2kPweXerkSNkJZlPTTh8I0C1JNIg1mFqu9xiFhHfcdpL5ssz+5/mjpGI4NxL8PP/WDayM+1TYe9rTFeCCi1j9oWs8fsvRlv769IOvZMx9xIGqcQJyjalIZyAJkbbbVu9NPEiz91kdjA2GHB3VLHyYN2s3e2MloQEyQuzBkLK28SYQJGAsZOHl3eRd75kB9X6g59b+fDoM+y8nhiI+Y4RNv7DS29D1xsh8HeGpzTDXsHnW4np5nSGnEdpXL8G4bopD87vqpO+4qlKy+Y8/vNj9w7BZO/TilL6yujUOdiNw1CKUz+dv/tXM7iLKyXZdHudoCdyAOQpE3JIP4WuGo2JOFeOAHiIAovA9eta4rAOz7fyPtgcvzgyQ/i1gZRbsfzNFusCSeHssPcNZ4oIejvA231RSE3KsOmFBLsyyi9Vo6hfMw9MAw0lm1VG7G3PakF5HyKS+zaWqPbXCdnoK63mphLPCF/an0L/WiZD8zl9ybf1s967aVGK9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PPF5D27497F1.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(7053199007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TqcHWZ/VPXy9hdzbJxuoUQrMDTjejB+n8BTXiBawOsCK7+eRuLK8L0vBDpWF?= =?us-ascii?Q?mgb7CgeIvL+EFzM78IXNNgebAWFKi6pIn+ypb1RPpAbnQ88VK4d4VAt69q0J?= =?us-ascii?Q?2Hl+OogRQfHkNKNqjNZ2ns9KzXl7yHlZCYm8XA/rZz4ZtmtQQmTc4k1BQoyO?= =?us-ascii?Q?WY+/hdDCWwNkgQlheV2bNG1aKvBkN1P16EUPWrNXyFZQqoVOz008lQ4g8xr8?= =?us-ascii?Q?QfZKXAxt1ZAmDOtv9Ed77+eSLpWD93MRrGZPk4zzlqzwX3XTPixgceZaEwjV?= =?us-ascii?Q?cgnZyDTT7QrqRbWbeI3QyJLlqbx+oUmjPA58Q5FB+0nCp3vHtQKOs4KezN5i?= =?us-ascii?Q?9qUyW6NVaOsw2IKixfdgsYV64PeZYVPou2BitDdiJ6A99iAy7u1n3QNAY7RI?= =?us-ascii?Q?KHNLjXkWpMcKAQBTfUmsoyVQDckan4prhy7Tpqn7dJa+OjBNt/LDQCaccJV+?= =?us-ascii?Q?iZwNrwOweg6N+SfDJ16kye6DovT5bJLQTCyt/rE7yhdBx2c5mCdh/I5LZ8Zu?= =?us-ascii?Q?Zb7i+NZOQX9jpOtkJ2rByPohSFRu07quqiI1yn+dYDPathkJA453jrUtxut4?= =?us-ascii?Q?SAc0Z4h8p1CS8NoRvk6s+hXS89Gd4JPln1jm7kOYnwztTNCbOCxgLA9bEqx+?= =?us-ascii?Q?UsWwj95Jx1wGoEtHz0TS8DxtKGgJBhxXUJeY92qhitn6RzZUscsEbOB9UafO?= =?us-ascii?Q?Ta3h0LXSaBMthW/L65+O+cB3c1MlOC9J2vZV0z6nfLksZDelueH5Ej3dy4O2?= =?us-ascii?Q?qePq8av0VLMhEhZRcCSQ3/3q2ARbAwYhTmv1RYAT7Z6DfyQw+z/LgoPhZpMY?= =?us-ascii?Q?31b+UeKmw/4+G6xjTwCNiqLo8FCAaKya7jaPpejQZh3N0A3Qkp+kZiJ8odae?= =?us-ascii?Q?wSTPGxD/OPksruTSxkpS9i7BEo+HYp7ZfDVQbG86FAXJ/h2L56/bEwcjLw8z?= =?us-ascii?Q?9JRFnyan+C1Srvevq/Ux4hcVGx5XGnRos1k5SUACz+AR4X7sTxyxMP8XqaWL?= =?us-ascii?Q?kfelQbETduW84AURAd58pSHauka5xoi1LlzcM6QA69GRlxysD7ALHNYoq+eK?= =?us-ascii?Q?d5A7NbmNXUq9Dv0EV6f9GkDhtHcvPGisSo43qmWzlaWdf2e7QtON4B2rUWP5?= =?us-ascii?Q?Ak2O3x5/r92wduRZGyIbd656O+oQ0n6X1SAtZkH0XU/LiNgwyRuXoml7C5bh?= =?us-ascii?Q?FJhDMc9UcqxWBeLoklOcAeSCUuqe5krNW3KPkKs56l3djC7QMXxYzN8OH+8k?= =?us-ascii?Q?53MUjCekaL9JToFa7lVa0YGM65y4J144tftMhzSom6YKcMkxlaLk5EV04mLZ?= =?us-ascii?Q?G8XSp9BXCBi2KzeXNlWn23AK+dSwxOSraZ7NqoZ1lagmshmqDY5qCZEWUDD2?= =?us-ascii?Q?g3LVwXuX79IcyBc/oZQPoiLD4vXKKtpEOd+DroikV1v7EU8ZL7+QS5ZYuN/R?= =?us-ascii?Q?GDEXuQGGR/6pxK/zbsuGKgxuAD+Y8cpb7SCAuvGQo8NFebzl2gDldoYOqNZZ?= =?us-ascii?Q?IpHLr4r+sn1gPPoQeyeNQVptNM6WRnir3APqB6poFDk6YkdpYlFhIGXfb/Ew?= =?us-ascii?Q?Xqt3iuN11CxMGEmr1SxBxPGH+lPs1KrVuuKsYahYI06yyIhSf7mM8Pw/AMC6?= =?us-ascii?Q?ii9eooJKjhraaZjgS88foRk+PhtEiqkXkhVr4/0/wEr29iBLEttAN9xR6Ts6?= =?us-ascii?Q?t/xJoCn4G/relF4M6/UBvOyN1pWayCc/Vh4+YxDHq3vq5SbI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PPF5D27497F1.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 682f363c-dfd5-4c1f-af77-08de7637e08f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2026 19:39:09.5822 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9LS4xJik0491iqIoXNzvhyqAgeopLRKr8kpVu7Ws0QqvbRqr3digdnwoS3SM0pce8i8ScEjrqiTlnYQjH+B8gA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSWPR12MB999151 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org [AMD Official Use Only - AMD Internal Distribution Only] Thank you for helping with my first binutils patch! Till next time, Allyson -----Original Message----- From: Simon Marchi Sent: Friday, February 27, 2026 2:33 PM To: Tom Tromey ; Cauble-Chantrenne, Allyson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Avoid minimal language when DW_LANG_HIP is used. [You don't often get email from simark@simark.ca. Learn why this is importa= nt at https://aka.ms/LearnAboutSenderIdentification ] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. On 2/18/26 1:39 PM, Tom Tromey wrote: >>>>>> Allyson Cauble-Chantrenne writes: > >> AMD clang is going to start using DW_LANG_HIP instead of >> DW_LANG_C_plus_plus_14 (see PR at >> https://github.com/llvm/llvm-project/pull/181738). Rather than >> falling back to the minimal language, this commit ensures that GDB >> will still treat it like a C++ app. The commit also adds a test to an >> existing one. > > This looks good to me, thank you. > Approved-By: Tom Tromey > > Tom Allyson asked me off-list to push the patch, so I went ahead and did it. I did a minor change, I tweaked the test prefix to just include the CU lang= , since that's the unique aspect of each variant: - with_test_prefix $gdb_lang { + with_test_prefix $cu_lang { Simon