From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Allyson Cauble-Chantrenne <acaublec@amd.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid minimal language when DW_LANG_HIP is used.
Date: Fri, 27 Feb 2026 14:32:57 -0500 [thread overview]
Message-ID: <4988dcb0-06fd-4dbc-953c-d980cef42a63@simark.ca> (raw)
In-Reply-To: <87o6ll7v74.fsf@tromey.com>
On 2/18/26 1:39 PM, Tom Tromey wrote:
>>>>>> Allyson Cauble-Chantrenne <acaublec@amd.com> writes:
>
>> AMD clang is going to start using DW_LANG_HIP instead of
>> DW_LANG_C_plus_plus_14 (see PR at
>> https://github.com/llvm/llvm-project/pull/181738). Rather than
>> falling back to the minimal language, this commit ensures that
>> GDB will still treat it like a C++ app. The commit also adds
>> a test to an existing one.
>
> This looks good to me, thank you.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Allyson asked me off-list to push the patch, so I went ahead and did it.
I did a minor change, I tweaked the test prefix to just include the CU
lang, since that's the unique aspect of each variant:
- with_test_prefix $gdb_lang {
+ with_test_prefix $cu_lang {
Simon
next prev parent reply other threads:[~2026-02-27 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 19:50 Allyson Cauble-Chantrenne
2026-02-18 18:39 ` Tom Tromey
2026-02-27 19:32 ` Simon Marchi [this message]
2026-02-27 19:39 ` Cauble-Chantrenne, Allyson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4988dcb0-06fd-4dbc-953c-d980cef42a63@simark.ca \
--to=simark@simark.ca \
--cc=acaublec@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox