From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KaMHHpDxoWn24wwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 14:33:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1772220816; bh=hHOniGuDEggnrBUmzkNBtKRQeR0wIGDIG9r7kJJKzcY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V1mOdDkXOsAue+Dx0WcxeGOckJUfHlA6GQEOXwEuHsUuq50B+Huk7UBZ6g8rkVrpi YFKVaIimZxPabKza5D9fNesQojaZyPe+NbtMDFQsOh6uvPP+wSpIckeT3L9LwybIDD 8yXk4Dhe5wlTCYV3aGriIam3VsbojmAGHZ+sRzsg= Received: by simark.ca (Postfix, from userid 112) id 737FA1E0DD; Fri, 27 Feb 2026 14:33:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=PeljFK97; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BBB101E089 for ; Fri, 27 Feb 2026 14:33:35 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 38CE14BA23E6 for ; Fri, 27 Feb 2026 19:33:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 38CE14BA23E6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=PeljFK97 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9EDF04BA23E8 for ; Fri, 27 Feb 2026 19:32:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9EDF04BA23E8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9EDF04BA23E8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772220779; cv=none; b=aWi24TETUoS1Acb4fIdbxw9ULIIaEiUTtW4hEkadrCTAEM8tcR+m737doVA2/rtWKxwiYnHN5G94RXxKbPym/v5l53lmIPnxypfYTeY0HPCCvTB/4xjy+VgH2/s47K+ELZbtnuuwJ2sZmxp91Ev+aolikM5jRwl5nJyNTSWjBhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772220779; c=relaxed/simple; bh=hHOniGuDEggnrBUmzkNBtKRQeR0wIGDIG9r7kJJKzcY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DYFdtR+mjMJqsuk9NFDpk2C5qtA2KxnTRGe0sX5DF447a5IMoWIQvWhYV6OjTSLWdBMnW9lYE4U1o3/A2UN5eJCaIiocYYYYVz9lUKTX4392KuurhHUA7g7H8lrxxg8EIEDZNlQONTJV11Oz59vQDlZKJbjCZSay0Wt4v79dWAM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EDF04BA23E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1772220779; bh=hHOniGuDEggnrBUmzkNBtKRQeR0wIGDIG9r7kJJKzcY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PeljFK976d0Lq4uw9NInrwV3ax6i/xHAhfZBj4f7azi6vfD6YwOBeB9YMIfqpAwAL 1dwpXX/iDycqSRdKiCZhFMqw3egsLfCsu5s3833i0VHz+Ynu1lYh6agvXHjCQ92xqh gxlUn6LshRK3Q11yZv3+sbTFnRtEuCwB1iNSDDeE= Received: by simark.ca (Postfix) id 1A26B1E089; Fri, 27 Feb 2026 14:32:57 -0500 (EST) Message-ID: <4988dcb0-06fd-4dbc-953c-d980cef42a63@simark.ca> Date: Fri, 27 Feb 2026 14:32:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Avoid minimal language when DW_LANG_HIP is used. To: Tom Tromey , Allyson Cauble-Chantrenne Cc: gdb-patches@sourceware.org References: <20260217195201.387306-1-acaublec@amd.com> <87o6ll7v74.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87o6ll7v74.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/18/26 1:39 PM, Tom Tromey wrote: >>>>>> Allyson Cauble-Chantrenne writes: > >> AMD clang is going to start using DW_LANG_HIP instead of >> DW_LANG_C_plus_plus_14 (see PR at >> https://github.com/llvm/llvm-project/pull/181738). Rather than >> falling back to the minimal language, this commit ensures that >> GDB will still treat it like a C++ app. The commit also adds >> a test to an existing one. > > This looks good to me, thank you. > Approved-By: Tom Tromey > > Tom Allyson asked me off-list to push the patch, so I went ahead and did it. I did a minor change, I tweaked the test prefix to just include the CU lang, since that's the unique aspect of each variant: - with_test_prefix $gdb_lang { + with_test_prefix $cu_lang { Simon