Another Darwin build fix

Another Darwin build fix

[Josh Matthews]

The system default gcc on 10.6.8 hits an uninitialized value warning
which causes the build to fail.

Cheers,
Josh

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f85f139..73803fd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2012-02-07  Josh Matthews  <josh@joshmatthews.net>  (tiny change)
+
+       Fix build error in Darwin port.
+       * machoread.c: Initialize nbr_syms to avoid warnings-as-errors failure.
+
 2012-02-07  Tom Tromey  <tromey@redhat.com>

        * charset.c (find_charset_names): Check 'in' against NULL.
diff --git a/gdb/machoread.c b/gdb/machoread.c
index 9fa97e1..88ce612 100644
--- a/gdb/machoread.c
+++ b/gdb/machoread.c
@@ -180,7 +180,7 @@ macho_symtab_read (struct objfile *objfile,
   const asymbol *dir_so = NULL;
   const asymbol *file_so = NULL;
   asymbol **oso_file = NULL;
-  unsigned int nbr_syms;
+  unsigned int nbr_syms = 0;

   /* Current state while reading stabs.  */
   enum

Re: Another Darwin build fix

[Tristan Gingold]

On Feb 7, 2012, at 9:47 PM, Josh Matthews wrote:

> The system default gcc on 10.6.8 hits an uninitialized value warning
> which causes the build to fail.

Ok, looks safe :-)
Do you need me to commit it ?

Thanks,
Tristan.

PS: the rule is to post the ChangeLog entry as is and not as a diff.  Also, no comment after your email address.
ie:

2012-02-07  Josh Matthews  <josh@joshmatthews.net>

       Fix build error in Darwin port
       * machoread.c: Initialize nbr_syms to avoid warnings-as-errors failure.


> 
> Cheers,
> Josh
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index f85f139..73803fd 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-02-07  Josh Matthews  <josh@joshmatthews.net>  (tiny change)
> +
> +       Fix build error in Darwin port.
> +       * machoread.c: Initialize nbr_syms to avoid warnings-as-errors failure.
> +
> 2012-02-07  Tom Tromey  <tromey@redhat.com>
> 
>        * charset.c (find_charset_names): Check 'in' against NULL.
> diff --git a/gdb/machoread.c b/gdb/machoread.c
> index 9fa97e1..88ce612 100644
> --- a/gdb/machoread.c
> +++ b/gdb/machoread.c
> @@ -180,7 +180,7 @@ macho_symtab_read (struct objfile *objfile,
>   const asymbol *dir_so = NULL;
>   const asymbol *file_so = NULL;
>   asymbol **oso_file = NULL;
> -  unsigned int nbr_syms;
> +  unsigned int nbr_syms = 0;
> 
>   /* Current state while reading stabs.  */
>   enum

Re: Another Darwin build fix

[Josh Matthews]

Yes, please. I'll follow those rules for the next build error I patch :)

Cheers,
Josh

On 8 February 2012 04:05, Tristan Gingold <gingold@adacore.com> wrote:
>
> On Feb 7, 2012, at 9:47 PM, Josh Matthews wrote:
>
>> The system default gcc on 10.6.8 hits an uninitialized value warning
>> which causes the build to fail.
>
> Ok, looks safe :-)
> Do you need me to commit it ?
>
> Thanks,
> Tristan.
>
> PS: the rule is to post the ChangeLog entry as is and not as a diff.  Also, no comment after your email address.
> ie:
>
> 2012-02-07  Josh Matthews  <josh@joshmatthews.net>
>
>       Fix build error in Darwin port
>       * machoread.c: Initialize nbr_syms to avoid warnings-as-errors failure.
>
>
>>
>> Cheers,
>> Josh
>>
>> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
>> index f85f139..73803fd 100644
>> --- a/gdb/ChangeLog
>> +++ b/gdb/ChangeLog
>> @@ -1,3 +1,8 @@
>> +2012-02-07  Josh Matthews  <josh@joshmatthews.net>  (tiny change)
>> +
>> +       Fix build error in Darwin port.
>> +       * machoread.c: Initialize nbr_syms to avoid warnings-as-errors failure.
>> +
>> 2012-02-07  Tom Tromey  <tromey@redhat.com>
>>
>>        * charset.c (find_charset_names): Check 'in' against NULL.
>> diff --git a/gdb/machoread.c b/gdb/machoread.c
>> index 9fa97e1..88ce612 100644
>> --- a/gdb/machoread.c
>> +++ b/gdb/machoread.c
>> @@ -180,7 +180,7 @@ macho_symtab_read (struct objfile *objfile,
>>   const asymbol *dir_so = NULL;
>>   const asymbol *file_so = NULL;
>>   asymbol **oso_file = NULL;
>> -  unsigned int nbr_syms;
>> +  unsigned int nbr_syms = 0;
>>
>>   /* Current state while reading stabs.  */
>>   enum
>