From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26239 invoked by alias); 8 Feb 2012 12:55:30 -0000 Received: (qmail 26227 invoked by uid 22791); 8 Feb 2012 12:55:28 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Feb 2012 12:55:15 +0000 Received: by pbcwz17 with SMTP id wz17so584977pbc.0 for ; Wed, 08 Feb 2012 04:55:15 -0800 (PST) Received: by 10.68.228.101 with SMTP id sh5mr69061369pbc.127.1328705715288; Wed, 08 Feb 2012 04:55:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.30.167 with HTTP; Wed, 8 Feb 2012 04:54:55 -0800 (PST) In-Reply-To: References: From: Josh Matthews Date: Wed, 08 Feb 2012 12:55:00 -0000 Message-ID: Subject: Re: Another Darwin build fix To: Tristan Gingold Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00100.txt.bz2 Yes, please. I'll follow those rules for the next build error I patch :) Cheers, Josh On 8 February 2012 04:05, Tristan Gingold wrote: > > On Feb 7, 2012, at 9:47 PM, Josh Matthews wrote: > >> The system default gcc on 10.6.8 hits an uninitialized value warning >> which causes the build to fail. > > Ok, looks safe :-) > Do you need me to commit it ? > > Thanks, > Tristan. > > PS: the rule is to post the ChangeLog entry as is and not as a diff. =A0A= lso, no comment after your email address. > ie: > > 2012-02-07 =A0Josh Matthews =A0 > > =A0 =A0 =A0 Fix build error in Darwin port > =A0 =A0 =A0 * machoread.c: Initialize nbr_syms to avoid warnings-as-error= s failure. > > >> >> Cheers, >> Josh >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index f85f139..73803fd 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,8 @@ >> +2012-02-07 =A0Josh Matthews =A0 =A0(tiny change) >> + >> + =A0 =A0 =A0 Fix build error in Darwin port. >> + =A0 =A0 =A0 * machoread.c: Initialize nbr_syms to avoid warnings-as-er= rors failure. >> + >> 2012-02-07 =A0Tom Tromey =A0 >> >> =A0 =A0 =A0 =A0* charset.c (find_charset_names): Check 'in' against NULL. >> diff --git a/gdb/machoread.c b/gdb/machoread.c >> index 9fa97e1..88ce612 100644 >> --- a/gdb/machoread.c >> +++ b/gdb/machoread.c >> @@ -180,7 +180,7 @@ macho_symtab_read (struct objfile *objfile, >> =A0 const asymbol *dir_so =3D NULL; >> =A0 const asymbol *file_so =3D NULL; >> =A0 asymbol **oso_file =3D NULL; >> - =A0unsigned int nbr_syms; >> + =A0unsigned int nbr_syms =3D 0; >> >> =A0 /* Current state while reading stabs. =A0*/ >> =A0 enum >