Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] comment: push_target: Fix comment
Date: Sun, 23 May 2010 17:32:00 -0000	[thread overview]
Message-ID: <AANLkTinUbzrf3jDgcSN1ud0Ix8-Z1y1sPg8BVYAq54yz@mail.gmail.com> (raw)
In-Reply-To: <20100523142948.GA4275@host0.dyn.jankratochvil.net>

On Sun, May 23, 2010 at 7:29 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi,
>
> I would like to update this comment but I was told one should not make
> references to other code in comments as such comment may become stale.
> OTOH unaware how to fix it otherwise, changing this code will most probably
> require updating the referenced add_target_sections code anyway.

For reference sake, comments that describe the function it is in have
also become stale!

While the likelihood is a bit higher here, I don't have a problem with it.


      reply	other threads:[~2010-05-23 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-23 17:06 Jan Kratochvil
2010-05-23 17:32 ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinUbzrf3jDgcSN1ud0Ix8-Z1y1sPg8BVYAq54yz@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox