From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32236 invoked by alias); 23 May 2010 17:06:49 -0000 Received: (qmail 32209 invoked by uid 22791); 23 May 2010 17:06:43 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 23 May 2010 17:06:39 +0000 Received: from hpaq13.eem.corp.google.com (hpaq13.eem.corp.google.com [172.25.149.13]) by smtp-out.google.com with ESMTP id o4NH6aYT017189 for ; Sun, 23 May 2010 10:06:37 -0700 Received: from pxi17 (pxi17.prod.google.com [10.243.27.17]) by hpaq13.eem.corp.google.com with ESMTP id o4NH6YRk028879 for ; Sun, 23 May 2010 10:06:35 -0700 Received: by pxi17 with SMTP id 17so976359pxi.39 for ; Sun, 23 May 2010 10:06:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.141.139.16 with SMTP id r16mr3182236rvn.187.1274634394080; Sun, 23 May 2010 10:06:34 -0700 (PDT) Received: by 10.140.255.14 with HTTP; Sun, 23 May 2010 10:06:34 -0700 (PDT) In-Reply-To: <20100523142948.GA4275@host0.dyn.jankratochvil.net> References: <20100523142948.GA4275@host0.dyn.jankratochvil.net> Date: Sun, 23 May 2010 17:32:00 -0000 Message-ID: Subject: Re: [patch] comment: push_target: Fix comment From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00537.txt.bz2 On Sun, May 23, 2010 at 7:29 AM, Jan Kratochvil wrote: > Hi, > > I would like to update this comment but I was told one should not make > references to other code in comments as such comment may become stale. > OTOH unaware how to fix it otherwise, changing this code will most probably > require updating the referenced add_target_sections code anyway. For reference sake, comments that describe the function it is in have also become stale! While the likelihood is a bit higher here, I don't have a problem with it.