From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] comment: push_target: Fix comment
Date: Sun, 23 May 2010 17:06:00 -0000 [thread overview]
Message-ID: <20100523142948.GA4275@host0.dyn.jankratochvil.net> (raw)
Hi,
I would like to update this comment but I was told one should not make
references to other code in comments as such comment may become stale.
OTOH unaware how to fix it otherwise, changing this code will most probably
require updating the referenced add_target_sections code anyway.
Thanks,
Jan
2010-05-23 Jan Kratochvil <jan.kratochvil@redhat.com>
* target.c (push_target): Fix comment wrt strata above.
--- gdb/target.c 23 May 2010 14:23:31 -0000 1.255
+++ gdb/target.c 23 May 2010 14:26:35 -0000
@@ -898,9 +898,8 @@ push_target (struct target_ops *t)
break;
}
- /* If there's already targets at this stratum, remove them. */
- /* FIXME: cagney/2003-10-15: I think this should be popping all
- targets to CUR, and not just those at this stratum level. */
+ /* If there's already targets at this stratum, remove them. Do not remove
+ targets at strata above, at least add_target_sections depends on it. */
while ((*cur) != NULL && t->to_stratum == (*cur)->to_stratum)
{
/* There's already something at this stratum level. Close it,
next reply other threads:[~2010-05-23 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 17:06 Jan Kratochvil [this message]
2010-05-23 17:32 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523142948.GA4275@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox