From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Delayed physnames, revisited
Date: Thu, 19 Aug 2010 23:26:00 -0000 [thread overview]
Message-ID: <AANLkTinRszypTZJ2WZ2rAH15ZqUh5CjP5cirr=kGQrAD@mail.gmail.com> (raw)
In-Reply-To: <m3iq362y55.fsf@fleche.redhat.com>
On Thu, Aug 19, 2010 at 12:36 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Sorry about the long delay on this.
> Please ping patches regularly, it helps embarrass us into responding ;-)
>
> Keith> I have finally gotten around to revisiting this patch and rebasing it
> Keith> on top of all the recent churn in dwarf2read.c. I have also (finally)
> Keith> developed a test case for the "trivial" obstack leak that I previously
> Keith> reported. [It was trivial, but also very dependent on compiler and STL
> Keith> implementation. That made it very non-trivial. :-)]
>
> This patch is ok. Thanks.
Not to nitpick or anything,
Well, yes to nitpick ... :-)
Folks are great at enforcing things like putting a space after the
function name in a function call, but not so good at enforcing having
a blank line between a function's comment and definition.
Keith, can you fix that?
next prev parent reply other threads:[~2010-08-19 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 21:01 Keith Seitz
2010-08-19 19:36 ` Tom Tromey
2010-08-19 23:26 ` Doug Evans [this message]
2010-08-20 17:17 ` Keith Seitz
2010-08-22 18:46 ` New UNRESOLVED testcase gdb.dwarf2/dw2-double-set-die-type.exp [Re: [RFA] Delayed physnames, revisited] Jan Kratochvil
2010-08-23 19:13 ` Keith Seitz
2010-08-20 17:50 ` [RFA] Delayed physnames, revisited Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinRszypTZJ2WZ2rAH15ZqUh5CjP5cirr=kGQrAD@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox