Re: New UNRESOLVED testcase gdb.dwarf2/dw2-double-set-die-type.exp [Re: [RFA] Delayed physnames, revisited]

[Keith Seitz <keiths@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On 08/22/2010 11:46 AM, Jan Kratochvil wrote:
> There is one missing end-of-DIE-children at the end of .debug_info.  But I do
> not know which specific DIE is not terminated before it.

Yes, there was. Turns out there were two *similar* abbrevs in the 
original program. I missed that one of them was marked DW_children_no 
and the other DW_children_yes. Creating a new abbrev with DW_children_no 
and using that fixes the problem.

>
> Also .debug_abbrev seems to be missing its terminating entry.

Yup. I've added that, too.

I've checked this in as obvious (and I have verified with Jan that 
everything now works).

Keith

ChangeLog
2010-08-23  Keith Seitz  <keiths@redhat.com>

	* gdb.dwarf2/dw2-double-set-die-type.S: DIE 0x51f does not
	have any children. Create a new abbrev for it.
	Add missing terminal sequence to .debug_abbrev.


[-- Attachment #2: double-die-no-children.patch --]
[-- Type: text/plain, Size: 1270 bytes --]

Index: testsuite/gdb.dwarf2/dw2-double-set-die-type.S
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/dw2-double-set-die-type.S,v
retrieving revision 1.1
diff -u -p -r1.1 dw2-double-set-die-type.S
--- testsuite/gdb.dwarf2/dw2-double-set-die-type.S	20 Aug 2010 17:16:15 -0000	1.1
+++ testsuite/gdb.dwarf2/dw2-double-set-die-type.S	23 Aug 2010 19:11:48 -0000
@@ -282,7 +282,7 @@
 	.byte	0x0	# end of children of DIE 0x505
 
 .Ldie_51f:
-	.uleb128 0x21	# (DIE (0x51f) DW_TAG_subprogram)
+	.uleb128 0x23	# (DIE (0x51f) DW_TAG_subprogram)
 	.byte	0x1	# DW_AT_external
 	.ascii	"_M_allocate\0"	# DW_AT_name
 	.long	OFFSET (277)	# DW_AT_type
@@ -630,3 +630,23 @@
 	.uleb128 0x13	# (DW_FORM_ref4)
 	.byte	0x0
 	.byte	0x0
+
+	.uleb128 0x23	# (abbrev code)
+	.uleb128 0x2e	# (TAG: DW_TAG_subprogram)
+	.byte	0x0	# DW_children_no
+	.uleb128 0x3f	# (DW_AT_external)
+	.uleb128 0xc	# (DW_FORM_flag)
+	.uleb128 0x3	# (DW_AT_name)
+	.uleb128 0x8	# (DW_FORM_string)
+	.uleb128 0x49	# (DW_AT_type)
+	.uleb128 0x13	# (DW_FORM_ref4)
+	.uleb128 0x3c	# (DW_AT_declaration)
+	.uleb128 0xc	# (DW_FORM_flag)
+	.uleb128 0x1	# (DW_AT_sibling)
+	.uleb128 0x13	# (DW_FORM_ref4)
+	.byte	0x0
+	.byte	0x0
+
+	.byte	0x0
+	.byte	0x0
+