From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28183 invoked by alias); 23 Aug 2010 19:13:01 -0000 Received: (qmail 28167 invoked by uid 22791); 23 Aug 2010 19:13:00 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Aug 2010 19:12:56 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7NJCtKP014420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Aug 2010 15:12:55 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7NJCq3Z024826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 Aug 2010 15:12:54 -0400 Message-ID: <4C72C834.7060803@redhat.com> Date: Mon, 23 Aug 2010 19:13:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: Jan Kratochvil Subject: Re: New UNRESOLVED testcase gdb.dwarf2/dw2-double-set-die-type.exp [Re: [RFA] Delayed physnames, revisited] References: <4C460EAC.3040600@redhat.com> <4C6EB87E.7070200@redhat.com> <20100822184631.GA28572@host1.dyn.jankratochvil.net> In-Reply-To: <20100822184631.GA28572@host1.dyn.jankratochvil.net> Content-Type: multipart/mixed; boundary="------------050209030802050809060308" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00394.txt.bz2 This is a multi-part message in MIME format. --------------050209030802050809060308 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 841 On 08/22/2010 11:46 AM, Jan Kratochvil wrote: > There is one missing end-of-DIE-children at the end of .debug_info. But I do > not know which specific DIE is not terminated before it. Yes, there was. Turns out there were two *similar* abbrevs in the original program. I missed that one of them was marked DW_children_no and the other DW_children_yes. Creating a new abbrev with DW_children_no and using that fixes the problem. > > Also .debug_abbrev seems to be missing its terminating entry. Yup. I've added that, too. I've checked this in as obvious (and I have verified with Jan that everything now works). Keith ChangeLog 2010-08-23 Keith Seitz * gdb.dwarf2/dw2-double-set-die-type.S: DIE 0x51f does not have any children. Create a new abbrev for it. Add missing terminal sequence to .debug_abbrev. --------------050209030802050809060308 Content-Type: text/plain; name="double-die-no-children.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="double-die-no-children.patch" Content-length: 1270 Index: testsuite/gdb.dwarf2/dw2-double-set-die-type.S =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/dw2-double-set-die-type.S,v retrieving revision 1.1 diff -u -p -r1.1 dw2-double-set-die-type.S --- testsuite/gdb.dwarf2/dw2-double-set-die-type.S 20 Aug 2010 17:16:15 -0000 1.1 +++ testsuite/gdb.dwarf2/dw2-double-set-die-type.S 23 Aug 2010 19:11:48 -0000 @@ -282,7 +282,7 @@ .byte 0x0 # end of children of DIE 0x505 .Ldie_51f: - .uleb128 0x21 # (DIE (0x51f) DW_TAG_subprogram) + .uleb128 0x23 # (DIE (0x51f) DW_TAG_subprogram) .byte 0x1 # DW_AT_external .ascii "_M_allocate\0" # DW_AT_name .long OFFSET (277) # DW_AT_type @@ -630,3 +630,23 @@ .uleb128 0x13 # (DW_FORM_ref4) .byte 0x0 .byte 0x0 + + .uleb128 0x23 # (abbrev code) + .uleb128 0x2e # (TAG: DW_TAG_subprogram) + .byte 0x0 # DW_children_no + .uleb128 0x3f # (DW_AT_external) + .uleb128 0xc # (DW_FORM_flag) + .uleb128 0x3 # (DW_AT_name) + .uleb128 0x8 # (DW_FORM_string) + .uleb128 0x49 # (DW_AT_type) + .uleb128 0x13 # (DW_FORM_ref4) + .uleb128 0x3c # (DW_AT_declaration) + .uleb128 0xc # (DW_FORM_flag) + .uleb128 0x1 # (DW_AT_sibling) + .uleb128 0x13 # (DW_FORM_ref4) + .byte 0x0 + .byte 0x0 + + .byte 0x0 + .byte 0x0 + --------------050209030802050809060308--