From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75078-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3819 invoked by alias); 19 Aug 2010 23:26:06 -0000
Received: (qmail 3788 invoked by uid 22791); 19 Aug 2010 23:26:05 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 23:26:00 +0000
Received: from wpaz13.hot.corp.google.com (wpaz13.hot.corp.google.com [172.24.198.77])	by smtp-out.google.com with ESMTP id o7JNPvDq022891	for <gdb-patches@sourceware.org>; Thu, 19 Aug 2010 16:25:57 -0700
Received: from vws7 (vws7.prod.google.com [10.241.21.135])	by wpaz13.hot.corp.google.com with ESMTP id o7JNPZUJ020342	for <gdb-patches@sourceware.org>; Thu, 19 Aug 2010 16:25:56 -0700
Received: by vws7 with SMTP id 7so3143445vws.27        for <gdb-patches@sourceware.org>; Thu, 19 Aug 2010 16:25:56 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.62.72 with SMTP id w8mr361144vch.32.1282260352657; Thu, 19 Aug 2010 16:25:52 -0700 (PDT)
Received: by 10.220.83.37 with HTTP; Thu, 19 Aug 2010 16:25:52 -0700 (PDT)
In-Reply-To: <m3iq362y55.fsf@fleche.redhat.com>
References: <4C460EAC.3040600@redhat.com>	<m3iq362y55.fsf@fleche.redhat.com>
Date: Thu, 19 Aug 2010 23:26:00 -0000
Message-ID: <AANLkTinRszypTZJ2WZ2rAH15ZqUh5CjP5cirr=kGQrAD@mail.gmail.com>
Subject: Re: [RFA] Delayed physnames, revisited
From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00360.txt.bz2

On Thu, Aug 19, 2010 at 12:36 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" =3D=3D Keith Seitz <keiths@redhat.com> writes:
>
> Sorry about the long delay on this.
> Please ping patches regularly, it helps embarrass us into responding ;-)
>
> Keith> I have finally gotten around to revisiting this patch and rebasing=
 it
> Keith> on top of all the recent churn in dwarf2read.c. I have also (final=
ly)
> Keith> developed a test case for the "trivial" obstack leak that I previo=
usly
> Keith> reported. [It was trivial, but also very dependent on compiler and=
 STL
> Keith> implementation. That made it very non-trivial. :-)]
>
> This patch is ok. =A0Thanks.

Not to nitpick or anything,
Well, yes to nitpick ... :-)

Folks are great at enforcing things like putting a space after the
function name in a function call, but not so good at enforcing having
a blank line between a function's comment and definition.

Keith, can you fix that?