From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] fix exp/12117
Date: Wed, 13 Oct 2010 18:55:00 -0000 [thread overview]
Message-ID: <AANLkTimyKxoOVrHAnKT7ueWqWyQ+tVE_k1NJrr7gX+3Q@mail.gmail.com> (raw)
In-Reply-To: <m34ocqaq6f.fsf@fleche.redhat.com>
On Wed, Oct 13, 2010 at 11:44 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> This patch fixes pr exp/12117.
> Doug> http://sourceware.org/bugzilla/show_bug.cgi?id=12117
>
> Doug> I will check this in in two days if there are no objections.
>
> It looks reasonable to me.
>
> Not an objection, but it seems odd that check_typedef can strip
> qualifiers from a type. It looks like it tries to do the right thing in
> some cases, but not all. Couldn't it just call make_qualified_type at
> the right point? Or unconditionally use that instead of checking
> TYPE_OBJFILE?
No disagreement that it's odd, and there may yet be more bugs in this area.
I thought of calling make_qualified_type, but I wasn't entirely
comfortable with it.
a) it seems like it's not just c/v, e.g., it's also the address space
[and perhaps here's a case where there are more bugs in this area :-)]
b) it seems odd to have to build such types on the fly
[I can imagine a proliferation of such objects that aren't attached to
anything concrete in the debug info, and just cause confusion]
next prev parent reply other threads:[~2010-10-13 18:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 17:53 Doug Evans
2010-10-13 18:03 ` Doug Evans
2010-10-13 18:44 ` Tom Tromey
2010-10-13 18:55 ` Doug Evans [this message]
2010-10-13 19:04 ` Tom Tromey
2010-10-13 20:55 ` Doug Evans
2010-10-13 21:10 ` Jan Kratochvil
2010-10-14 1:55 ` Doug Evans
2010-10-14 9:35 ` Jan Kratochvil
2010-10-15 17:42 ` Tom Tromey
2010-10-15 17:49 ` Jan Kratochvil
2010-10-15 17:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimyKxoOVrHAnKT7ueWqWyQ+tVE_k1NJrr7gX+3Q@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox