From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: [patch] fix exp/12117
Date: Fri, 15 Oct 2010 17:41:00 -0000 [thread overview]
Message-ID: <m3hbgn5p78.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101013211008.GA23114@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Wed, 13 Oct 2010 23:10:08 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Doug> a) it seems like it's not just c/v, e.g., it's also the address space
Doug> [and perhaps here's a case where there are more bugs in this area :-)]
Tom> Yeah. Actually, this one seems like it could cause real problems
Tom> somewhere.
Jan> I may see it too naively but isn't the attached patch OK? I see no
Jan> instance flags or objfile ownership problem there.
Sorry, all I meant here is that stripping the address space qualifiers
in check_typedef is likely to be a source of bugs, because gdb calls
check_typedef all over the place, and presumably these bits translate
into some important target-specific difference in how memory is
accessed.
Tom
prev parent reply other threads:[~2010-10-15 17:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 17:53 Doug Evans
2010-10-13 18:03 ` Doug Evans
2010-10-13 18:44 ` Tom Tromey
2010-10-13 18:55 ` Doug Evans
2010-10-13 19:04 ` Tom Tromey
2010-10-13 20:55 ` Doug Evans
2010-10-13 21:10 ` Jan Kratochvil
2010-10-14 1:55 ` Doug Evans
2010-10-14 9:35 ` Jan Kratochvil
2010-10-15 17:42 ` Tom Tromey
2010-10-15 17:49 ` Jan Kratochvil
2010-10-15 17:41 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hbgn5p78.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox