From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1672 invoked by alias); 13 Oct 2010 18:55:37 -0000 Received: (qmail 1661 invoked by uid 22791); 13 Oct 2010 18:55:36 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Oct 2010 18:55:29 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id o9DItR88027742 for ; Wed, 13 Oct 2010 11:55:27 -0700 Received: from pvf33 (pvf33.prod.google.com [10.241.210.97]) by wpaz29.hot.corp.google.com with ESMTP id o9DItQ2C000314 for ; Wed, 13 Oct 2010 11:55:26 -0700 Received: by pvf33 with SMTP id 33so1082346pvf.0 for ; Wed, 13 Oct 2010 11:55:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.13.19 with SMTP id 19mr7917579wfm.406.1286996125672; Wed, 13 Oct 2010 11:55:25 -0700 (PDT) Received: by 10.220.118.2 with HTTP; Wed, 13 Oct 2010 11:55:25 -0700 (PDT) In-Reply-To: References: <20101013175308.17B772461AE@ruffy.mtv.corp.google.com> Date: Wed, 13 Oct 2010 18:55:00 -0000 Message-ID: Subject: Re: [patch] fix exp/12117 From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00232.txt.bz2 On Wed, Oct 13, 2010 at 11:44 AM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > > Doug> This patch fixes pr exp/12117. > Doug> http://sourceware.org/bugzilla/show_bug.cgi?id=3D12117 > > Doug> I will check this in in two days if there are no objections. > > It looks reasonable to me. > > Not an objection, but it seems odd that check_typedef can strip > qualifiers from a type. =A0It looks like it tries to do the right thing in > some cases, but not all. =A0Couldn't it just call make_qualified_type at > the right point? =A0Or unconditionally use that instead of checking > TYPE_OBJFILE? No disagreement that it's odd, and there may yet be more bugs in this area. I thought of calling make_qualified_type, but I wasn't entirely comfortable with it. a) it seems like it's not just c/v, e.g., it's also the address space [and perhaps here's a case where there are more bugs in this area :-)] b) it seems odd to have to build such types on the fly [I can imagine a proliferation of such objects that aren't attached to anything concrete in the debug info, and just cause confusion]