Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <pedro@codesourcery.com>,
	       Tom Tromey <tromey@redhat.com>
Subject: Re: [RFA] c++/11734
Date: Thu, 24 Jun 2010 16:05:00 -0000	[thread overview]
Message-ID: <AANLkTimi3uthR6gGfa9lSUq6LQXuSBGE8E6M2eDy7_i3@mail.gmail.com> (raw)
In-Reply-To: <AANLkTil8J9g3Z3mJn0Tcw225FAlU-e1CNKmFblwb9hmt@mail.gmail.com>

On Wed, Jun 23, 2010 at 7:25 PM, Doug Evans <dje@google.com> wrote:
> From Keith's patch:
> +             if (simple_name)
> +               {
> +                 /* NAME has overload information.  Partial symbols, however,
> +                    do not.  This is a case of mistaken identity.
> +
> +                    Although hacky, this is fixed by expanding this psymtab,
> +                    which will allow any subsequent symtab search to succeed.
> +
> +                    For more details/test case, please refer to c++/11734.  */
> +
> +                 if (SYMBOL_MATCHES_SEARCH_NAME (*top, simple_name))
> +                   PSYMTAB_TO_SYMTAB (pst);
> +               }
> [...]
> I don't have a specific proposal for a better fix at the moment.

Maybe after expanding the psymtab you could search the full symtab here?
Still hacky, but maybe good enough for 7.2?


  parent reply	other threads:[~2010-06-24 16:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22  1:22 Keith Seitz
2010-06-22  9:45 ` Pedro Alves
2010-06-22 15:43   ` Keith Seitz
2010-06-23 17:33     ` Keith Seitz
2010-06-24  2:25     ` Doug Evans
2010-06-24 11:39       ` Matt Rice
2010-06-24 16:05       ` Doug Evans [this message]
2010-06-24 20:01       ` Tom Tromey
2010-06-24 20:49         ` Doug Evans
2010-06-24 20:51       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimi3uthR6gGfa9lSUq6LQXuSBGE8E6M2eDy7_i3@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox