From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25228 invoked by alias); 24 Jun 2010 16:05:17 -0000 Received: (qmail 25032 invoked by uid 22791); 24 Jun 2010 16:05:15 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_STOCKGEN,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jun 2010 16:05:11 +0000 Received: from hpaq3.eem.corp.google.com (hpaq3.eem.corp.google.com [172.25.149.3]) by smtp-out.google.com with ESMTP id o5OG581U017119 for ; Thu, 24 Jun 2010 09:05:09 -0700 Received: from vws15 (vws15.prod.google.com [10.241.21.143]) by hpaq3.eem.corp.google.com with ESMTP id o5OG56SZ004143 for ; Thu, 24 Jun 2010 09:05:07 -0700 Received: by vws15 with SMTP id 15so991648vws.35 for ; Thu, 24 Jun 2010 09:05:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.121.217 with SMTP id i25mr5199195vcr.0.1277395506316; Thu, 24 Jun 2010 09:05:06 -0700 (PDT) Received: by 10.220.201.66 with HTTP; Thu, 24 Jun 2010 09:05:06 -0700 (PDT) In-Reply-To: References: <4C20103B.1080906@redhat.com> <201006221045.23196.pedro@codesourcery.com> <4C20DA1A.10301@redhat.com> Date: Thu, 24 Jun 2010 16:05:00 -0000 Message-ID: Subject: Re: [RFA] c++/11734 From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00532.txt.bz2 On Wed, Jun 23, 2010 at 7:25 PM, Doug Evans wrote: > From Keith's patch: > + =A0 =A0 =A0 =A0 =A0 =A0 if (simple_name) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 { > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* NAME has overload information. =A0Pa= rtial symbols, however, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0do not. =A0This is a case of mis= taken identity. > + > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Although hacky, this is fixed by= expanding this psymtab, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0which will allow any subsequent = symtab search to succeed. > + > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0For more details/test case, plea= se refer to c++/11734. =A0*/ > + > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (SYMBOL_MATCHES_SEARCH_NAME (*top, s= imple_name)) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 PSYMTAB_TO_SYMTAB (pst); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 } > [...] > I don't have a specific proposal for a better fix at the moment. Maybe after expanding the psymtab you could search the full symtab here? Still hacky, but maybe good enough for 7.2?