Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] c++/11734
Date: Wed, 23 Jun 2010 17:33:00 -0000	[thread overview]
Message-ID: <4C224575.4030209@redhat.com> (raw)
In-Reply-To: <4C20DA1A.10301@redhat.com>

On 06/22/2010 08:43 AM, Keith Seitz wrote:
> I noticed that I also missed adding this logic to the linear search
> case. I've attached a revised patch which addresses this missed bit and
> moves the alloca out of the loop.

BTW, after reviewing my own patch again, I think it should not break out 
of either loop prematurely: an exact match might later appear in the list.

While this doesn't really affect the ultimate outcome (because we know 
that symtabs will be searched next), prematurely breaking could cause 
lookup_partial_symbol to return NULL when an exact match is really found.

Keith


  reply	other threads:[~2010-06-23 17:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22  1:22 Keith Seitz
2010-06-22  9:45 ` Pedro Alves
2010-06-22 15:43   ` Keith Seitz
2010-06-23 17:33     ` Keith Seitz [this message]
2010-06-24  2:25     ` Doug Evans
2010-06-24 11:39       ` Matt Rice
2010-06-24 16:05       ` Doug Evans
2010-06-24 20:01       ` Tom Tromey
2010-06-24 20:49         ` Doug Evans
2010-06-24 20:51       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C224575.4030209@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox