From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21354 invoked by alias); 23 Jun 2010 17:33:49 -0000 Received: (qmail 21343 invoked by uid 22791); 23 Jun 2010 17:33:47 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Jun 2010 17:33:45 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5NHXh69004437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Jun 2010 13:33:43 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5NHXf2T022790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 23 Jun 2010 13:33:43 -0400 Message-ID: <4C224575.4030209@redhat.com> Date: Wed, 23 Jun 2010 17:33:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFA] c++/11734 References: <4C20103B.1080906@redhat.com> <201006221045.23196.pedro@codesourcery.com> <4C20DA1A.10301@redhat.com> In-Reply-To: <4C20DA1A.10301@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00506.txt.bz2 On 06/22/2010 08:43 AM, Keith Seitz wrote: > I noticed that I also missed adding this logic to the linear search > case. I've attached a revised patch which addresses this missed bit and > moves the alloca out of the loop. BTW, after reviewing my own patch again, I think it should not break out of either loop prematurely: an exact match might later appear in the list. While this doesn't really affect the ultimate outcome (because we know that symtabs will be searched next), prematurely breaking could cause lookup_partial_symbol to return NULL when an exact match is really found. Keith