From: Mike Frysinger <vapier@gentoo.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH v3] sim: cfi: new flash device simulation
Date: Fri, 25 Mar 2011 21:23:00 -0000 [thread overview]
Message-ID: <AANLkTikOQ+ECGiG4A5j-h4qJYmq98yHCGZMHyYaZ8Bi5@mail.gmail.com> (raw)
In-Reply-To: <20110325192911.GH4401@redhat.com>
On Fri, Mar 25, 2011 at 3:29 PM, Frank Ch. Eigler wrote:
> On Fri, Mar 25, 2011 at 03:19:28PM -0400, Mike Frysinger wrote:
>> [...]
>> > Woudln't you want to write(2) out the contents of the flash backing
>> > store file, if !HAVE_MMAP?
>>
>> perhaps, but that'd require quite a bit more logic that just a single
>> call to write() here. frankly, i dont care about the systems that
>> dont support mmap as required by POSIX. the ifdef's are only to keep
>> from breaking their builds. [...]
>
> I see. If you don't want to implement write() or fwrite() in a
> symmetric way to the read path, you could make sure that a !HAVE_MMAP
> machine would reject the configuration of a cfi model in "rw"
> file-backed mode.
i'll have it issue a warning that the rw mode is not supported, but
otherwise it'll continue to work
-mike
next prev parent reply other threads:[~2011-03-25 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 19:32 Mike Frysinger
2011-03-25 21:07 ` Frank Ch. Eigler
2011-03-25 21:23 ` Mike Frysinger [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-31 6:33 [PATCH] " Mike Frysinger
2011-03-25 9:49 ` [PATCH v3] " Mike Frysinger
2011-03-25 15:55 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikOQ+ECGiG4A5j-h4qJYmq98yHCGZMHyYaZ8Bi5@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=fche@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox