From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH v3] sim: cfi: new flash device simulation
Date: Fri, 25 Mar 2011 15:55:00 -0000 [thread overview]
Message-ID: <20110325154634.GO2520@adacore.com> (raw)
In-Reply-To: <1301012212-2372-1-git-send-email-vapier@gentoo.org>
> gdb/:
> 2011-03-24 Mike Frysinger <vapier@gentoo.org>
>
> * NEWS: Mention new cfi device simulation.
>
> sim/common/:
> 2011-03-24 Mike Frysinger <vapier@gentoo.org>
>
> * aclocal.m4 (SIM_AC_OPTION_HARDWARE): Add cfi to default list.
> * Make-common.in (dv-cfi.o): New rule.
> * dv-cfi.c, dv-cfi.h: New files.
It's great to see the code with the comments, thanks! If you are going
to produce a 4th version based on Frank's comments, it would be nice
to reformat the comments a little to limit the length to 70 characters.
That's the soft limit we decided on recently. We allow ourselves to go
beyond that limit if it helping making thing less ugly, but otherwise,
we try to stay within that limit. If you're not going to produce
a new version, then no worries about that.
--
Joel
next prev parent reply other threads:[~2011-03-25 15:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 6:33 [PATCH] " Mike Frysinger
2011-02-07 6:11 ` Mike Frysinger
2011-03-15 20:11 ` Mike Frysinger
2011-03-24 11:24 ` [PATCH v2] " Mike Frysinger
2011-03-24 15:50 ` Joel Brobecker
2011-03-25 0:13 ` Mike Frysinger
2011-03-25 9:49 ` [PATCH v3] " Mike Frysinger
2011-03-25 15:55 ` Joel Brobecker [this message]
[not found] ` <1301012212-2372-1-git-send-email-vapier__17299.0819243298$1301012210$gmane$org@gentoo.org>
2011-03-25 15:54 ` =?UTF-8?q?=5BPATCH=20v3=5D=20sim=3A=20cfi=3A=20new=20flash=20device=20simulation?= Frank Ch. Eigler
2011-03-26 7:00 ` [PATCH v4] sim: cfi: new flash device simulation Mike Frysinger
2011-03-29 15:41 ` Joel Brobecker
2011-03-29 20:22 ` Mike Frysinger
2011-03-25 19:32 [PATCH v3] " Mike Frysinger
2011-03-25 21:07 ` Frank Ch. Eigler
2011-03-25 21:23 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325154634.GO2520@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox