From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15459 invoked by alias); 25 Mar 2011 15:46:54 -0000 Received: (qmail 15406 invoked by uid 22791); 25 Mar 2011 15:46:53 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Mar 2011 15:46:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 00CB22BB2EF; Fri, 25 Mar 2011 11:46:49 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vUT68Awt0dBQ; Fri, 25 Mar 2011 11:46:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A7A6D2BB1BD; Fri, 25 Mar 2011 11:46:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8E04E1459BD; Fri, 25 Mar 2011 08:46:34 -0700 (PDT) Date: Fri, 25 Mar 2011 15:55:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH v3] sim: cfi: new flash device simulation Message-ID: <20110325154634.GO2520@adacore.com> References: <1293750414-14626-1-git-send-email-vapier@gentoo.org> <1301012212-2372-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1301012212-2372-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01095.txt.bz2 > gdb/: > 2011-03-24 Mike Frysinger > > * NEWS: Mention new cfi device simulation. > > sim/common/: > 2011-03-24 Mike Frysinger > > * aclocal.m4 (SIM_AC_OPTION_HARDWARE): Add cfi to default list. > * Make-common.in (dv-cfi.o): New rule. > * dv-cfi.c, dv-cfi.h: New files. It's great to see the code with the comments, thanks! If you are going to produce a 4th version based on Frank's comments, it would be nice to reformat the comments a little to limit the length to 70 characters. That's the soft limit we decided on recently. We allow ourselves to go beyond that limit if it helping making thing less ugly, but otherwise, we try to stay within that limit. If you're not going to produce a new version, then no worries about that. -- Joel