From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12234 invoked by alias); 25 Mar 2011 19:32:45 -0000 Received: (qmail 12224 invoked by uid 22791); 25 Mar 2011 19:32:45 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iw0-f169.google.com (HELO mail-iw0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Mar 2011 19:32:40 +0000 Received: by iwg8 with SMTP id 8so1107624iwg.0 for ; Fri, 25 Mar 2011 12:32:40 -0700 (PDT) Received: by 10.42.134.132 with SMTP id l4mr1825918ict.13.1301081560120; Fri, 25 Mar 2011 12:32:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.11.195 with HTTP; Fri, 25 Mar 2011 12:32:20 -0700 (PDT) In-Reply-To: <20110325192911.GH4401@redhat.com> References: <20110325192911.GH4401@redhat.com> From: Mike Frysinger Date: Fri, 25 Mar 2011 21:23:00 -0000 Message-ID: Subject: Re: [PATCH v3] sim: cfi: new flash device simulation To: "Frank Ch. Eigler" Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01106.txt.bz2 On Fri, Mar 25, 2011 at 3:29 PM, Frank Ch. Eigler wrote: > On Fri, Mar 25, 2011 at 03:19:28PM -0400, Mike Frysinger wrote: >> [...] >> > Woudln't you want to write(2) out the contents of the flash backing >> > store file, if !HAVE_MMAP? >> >> perhaps, but that'd require quite a bit more logic that just a single >> call to write() here. =A0frankly, i dont care about the systems that >> dont support mmap as required by POSIX. =A0the ifdef's are only to keep >> from breaking their builds. [...] > > I see. =A0If you don't want to implement write() or fwrite() in a > symmetric way to the read path, you could make sure that a !HAVE_MMAP > machine would reject the configuration of a cfi model in "rw" > file-backed mode. i'll have it issue a warning that the rw mode is not supported, but otherwise it'll continue to work -mike