From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: RE: [PATCH v3 2/5] btrace: allow recording to be started (and stopped) for running threads
Date: Wed, 01 Feb 2017 08:53:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B23400471BF@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1b369026-46a2-199c-ec6d-8302a462c10f@redhat.com>
> > I was also thinking of changing the error messages to refer to the argument
> > thread but that would make them less clear when PTID really refers to the
> > selected thread - which should be the case most of the time if not always.
> >
> > Maybe this is not an issue in practice and the "selected thread" errors are
> > understandable enough. What do you think?
>
> I think we may be able to sidestep deciding this. :-)
That seems to work. I added a few tests to cover other record commands
while threads are running.
Thanks,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2017-02-01 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 10:05 [PATCH v3 0/5] thread, btrace: allow "record btrace" " Markus Metzger
2017-01-30 10:05 ` [PATCH v3 4/5] btrace, testsuite: fix extended-remote non-stop test Markus Metzger
2017-01-31 13:00 ` Pedro Alves
2017-01-30 10:06 ` [PATCH v3 2/5] btrace: allow recording to be started (and stopped) for running threads Markus Metzger
2017-01-31 12:59 ` Pedro Alves
2017-01-31 16:06 ` Metzger, Markus T
2017-01-31 16:36 ` Pedro Alves
2017-02-01 8:53 ` Metzger, Markus T [this message]
2017-02-01 9:08 ` Metzger, Markus T
2017-02-01 10:40 ` Pedro Alves
2017-01-30 10:06 ` [PATCH v3 3/5] btrace: add unsupported/untested messages when skipping tests Markus Metzger
2017-01-31 13:00 ` Pedro Alves
2017-01-30 10:06 ` [PATCH v3 1/5] thread: add can_access_registers_ptid Markus Metzger
2017-01-30 10:06 ` [PATCH v3 5/5] btrace, testsuite: fix extended-remote fail Markus Metzger
2017-01-31 13:00 ` Pedro Alves
2017-01-31 16:06 ` Metzger, Markus T
2017-01-31 16:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B23400471BF@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox