From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12748 invoked by alias); 1 Feb 2017 08:53:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12722 invoked by uid 89); 1 Feb 2017 08:53:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:948, H*f:sk:1b36902, H*MI:sk:1b36902, H*i:sk:1b36902 X-HELO: mga07.intel.com Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Feb 2017 08:53:36 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 01 Feb 2017 00:53:34 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga004.fm.intel.com with ESMTP; 01 Feb 2017 00:53:32 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by IRSMSX102.ger.corp.intel.com ([169.254.2.230]) with mapi id 14.03.0248.002; Wed, 1 Feb 2017 08:53:09 +0000 From: "Metzger, Markus T" To: Pedro Alves , "gdb-patches@sourceware.org" CC: Simon Marchi Subject: RE: [PATCH v3 2/5] btrace: allow recording to be started (and stopped) for running threads Date: Wed, 01 Feb 2017 08:53:00 -0000 Message-ID: References: <1485770743-6603-1-git-send-email-markus.t.metzger@intel.com> <1485770743-6603-3-git-send-email-markus.t.metzger@intel.com> <1b369026-46a2-199c-ec6d-8302a462c10f@redhat.com> In-Reply-To: <1b369026-46a2-199c-ec6d-8302a462c10f@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00006.txt.bz2 > > I was also thinking of changing the error messages to refer to the argu= ment > > thread but that would make them less clear when PTID really refers to t= he > > selected thread - which should be the case most of the time if not alwa= ys. > > > > Maybe this is not an issue in practice and the "selected thread" errors= are > > understandable enough. What do you think? >=20 > I think we may be able to sidestep deciding this. :-) That seems to work. I added a few tests to cover other record commands while threads are running. Thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928