From: Pedro Alves <palves@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 5/5] btrace, testsuite: fix extended-remote fail
Date: Tue, 31 Jan 2017 16:42:00 -0000 [thread overview]
Message-ID: <0da258b6-eb52-624e-4d3a-eb70fb1e207e@redhat.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2340046F7F@IRSMSX104.ger.corp.intel.com>
On 01/31/2017 04:06 PM, Metzger, Markus T wrote:
> There's a comment in lib/gdb.exp before gdb_skip_xml_test, which is called
> by skip_gdbserver_tests:
>
> # Return true if a test should be skipped due to lack of XML support
> # in the host GDB.
> # NOTE: This must be called while gdb is *not* running.
>
> gdb_caching_proc gdb_skip_xml_test {
Ah, that starts gdb itself, runs "set tdesc filename" and then
exits gdb. Indeed, that can't work in the middle of some
other test... A command without side effects ("maint check-supports-xml"
or something), would avoid this... But let's not bother.
> I thought this is supposed to be general knowledge so I didn't bother to go into more
> detail in the commit message.
I don't recall ever noticing this before.
> Looks like we don't need the return, though. And the check should
> probably go into skip_xml_tests. Let me add a separate patch for this.
Thanks!
--
Pedro Alves
prev parent reply other threads:[~2017-01-31 16:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 10:05 [PATCH v3 0/5] thread, btrace: allow "record btrace" for running threads Markus Metzger
2017-01-30 10:05 ` [PATCH v3 4/5] btrace, testsuite: fix extended-remote non-stop test Markus Metzger
2017-01-31 13:00 ` Pedro Alves
2017-01-30 10:06 ` [PATCH v3 2/5] btrace: allow recording to be started (and stopped) for running threads Markus Metzger
2017-01-31 12:59 ` Pedro Alves
2017-01-31 16:06 ` Metzger, Markus T
2017-01-31 16:36 ` Pedro Alves
2017-02-01 8:53 ` Metzger, Markus T
2017-02-01 9:08 ` Metzger, Markus T
2017-02-01 10:40 ` Pedro Alves
2017-01-30 10:06 ` [PATCH v3 3/5] btrace: add unsupported/untested messages when skipping tests Markus Metzger
2017-01-31 13:00 ` Pedro Alves
2017-01-30 10:06 ` [PATCH v3 1/5] thread: add can_access_registers_ptid Markus Metzger
2017-01-30 10:06 ` [PATCH v3 5/5] btrace, testsuite: fix extended-remote fail Markus Metzger
2017-01-31 13:00 ` Pedro Alves
2017-01-31 16:06 ` Metzger, Markus T
2017-01-31 16:42 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0da258b6-eb52-624e-4d3a-eb70fb1e207e@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox