From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47258 invoked by alias); 31 Jan 2017 16:42:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47249 invoked by uid 89); 31 Jan 2017 16:42:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:993 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Jan 2017 16:42:29 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F01461BA2; Tue, 31 Jan 2017 16:42:29 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7166C1DCFB; Tue, 31 Jan 2017 16:42:28 +0000 (UTC) Subject: Re: [PATCH v3 5/5] btrace, testsuite: fix extended-remote fail To: "Metzger, Markus T" , "gdb-patches@sourceware.org" References: <1485770743-6603-1-git-send-email-markus.t.metzger@intel.com> <1485770743-6603-6-git-send-email-markus.t.metzger@intel.com> <217e1c28-070a-f485-aa06-a91f69c31023@redhat.com> From: Pedro Alves Message-ID: <0da258b6-eb52-624e-4d3a-eb70fb1e207e@redhat.com> Date: Tue, 31 Jan 2017 16:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00674.txt.bz2 On 01/31/2017 04:06 PM, Metzger, Markus T wrote: > There's a comment in lib/gdb.exp before gdb_skip_xml_test, which is called > by skip_gdbserver_tests: > > # Return true if a test should be skipped due to lack of XML support > # in the host GDB. > # NOTE: This must be called while gdb is *not* running. > > gdb_caching_proc gdb_skip_xml_test { Ah, that starts gdb itself, runs "set tdesc filename" and then exits gdb. Indeed, that can't work in the middle of some other test... A command without side effects ("maint check-supports-xml" or something), would avoid this... But let's not bother. > I thought this is supposed to be general knowledge so I didn't bother to go into more > detail in the commit message. I don't recall ever noticing this before. > Looks like we don't need the return, though. And the check should > probably go into skip_xml_tests. Let me add a separate patch for this. Thanks! -- Pedro Alves